[MUI2] Add basic magnet implementation#4599
Draft
jurrejelle wants to merge 1 commit intomui2-refactorfrom
Draft
Conversation
jurrejelle
added
type: refactor
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Basic, almost 1:1 implementation of magnets from LDLib to MUI
Draft because right now onCloseListeners aren't called and we use those to save the magnets filter data to NBT
How Was This Tested
In game but it doesn't work yet lol
Currently, this naively re-builds the filter. This is because the filter's MUI code creates a ModularPanel, but I need to embed it into the magnet's UI. It's worth considering if we want to somehow de-duplicate this.