Open
Conversation
YoungOnionMC
previously approved these changes
Feb 8, 2026
Member
|
how come the CONFIG_SIZE value was removed for the ae part hatches? |
YoungOnionMC
added
type: feature
Ghostipedia
dismissed
YoungOnionMC’s stale review
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes Item Buses to use a Function to supply their inventory instead of the super constructor calling a method. This prevents initialization order problems, where the
createInventory()function would like to use instance variables defined in a subclass, but the superclass calls it before the subclass's variables are initialized.This PR adds static factory methods to create all of the item bus classes to make registration easier, but leaves function-based constructors on all classes to keep future subclassing available as needed.
Outcome
Allows for cleaner item bus initialization order, prevents non-obvious bugs due to the above scenario.
How Was This Tested
I did a brief test to make sure all the buses worked as expected.