Full refactor of MetaMachine to merge MetaMachine and MetaMachineBlockEntity class and rework the machine inheritance tree #4304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustovafing
added
Do Not Merge
gustovafing
force-pushed
the
gus/refactor-machine-construction
branch
from
8244e82 to
9626f7a
Compare
gustovafing
removed
Do Not Merge
github-actions
bot
added
Tests: Passed
gustovafing
force-pushed
the
gus/refactor-machine-construction
branch
from
b428190 to
6524987
Compare
github-actions
bot
added
Tests: Failed
TechLord22
reviewed
Dec 28, 2025
src/main/java/com/gregtechceu/gtceu/api/blockentity/PipeBlockEntity.java
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/capability/GTCapabilityHelper.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| } | ||
| // if (is(tool, GTToolType.HARD_HAMMER)) { |
Member
There was a problem hiding this comment.
What's the status on this code?
| import net.minecraft.world.level.block.state.BlockState; | ||
| import net.minecraftforge.common.extensions.IForgeBlockEntity; | ||
|
|
||
| public interface IGregtechBlockEntity extends ISyncManaged, ITickSubscription, IForgeBlockEntity { |
Member
There was a problem hiding this comment.
There's probably a better name for this.
| public interface ICoverable extends ITickSubscription, ISyncManaged { | ||
|
|
||
| Level getLevel(); | ||
| IGregtechBlockEntity getHolder(); |
Member
There was a problem hiding this comment.
There's probably a better name for this.
src/main/java/com/gregtechceu/gtceu/common/machine/electric/WorldAcceleratorMachine.java
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/AssemblyLineMachine.java
Outdated
Show resolved
Hide resolved
...ain/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/MultiblockTankMachine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/DiodePartMachine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/syncsystem/ManagedSyncBlockEntity.java
Outdated
Show resolved
Hide resolved
Co-authored-by: TechLord22 <37029404+TechLord22@users.noreply.github.com>
…m/GregTechCEu/GregTech-Modern into gus/refactor-machine-construction
TechLord22
reviewed
Jan 2, 2026
| return list; | ||
| } | ||
|
|
||
| public static @NotNull <T> LazyOptional<T> getCapability(MetaMachine machine, @NotNull Capability<T> cap, |
Member
There was a problem hiding this comment.
Can this be made private? Also, this should be made non-static and the machine param removed.
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTrait.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTrait.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTrait.java
Outdated
Show resolved
Hide resolved
| protected void checkAutoOutput() { | ||
| if (getOffsetTimer() % ticksPerCycle == 0) { | ||
| if (isAutoOutputItems() && getOutputFacingItems() != null) { | ||
| if (isAutoOutputItems()) { |
Member
There was a problem hiding this comment.
Is removing the null check safe?
gustovafing
force-pushed
the
gus/refactor-machine-construction
branch
from
173fab8 to
940864e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fully refactors MetaMachine to remove the seperation between the machine class and the block entity which holds the machine. All references to MMBE have been updated to use MetaMachine directly.
Also contains a number of general refactors to the machine inheritance tree and machine constructors.
TODO: Write a ton of migration docs
Potential Compatibility Issues
there will be at least one compatibility issue, maybe even two