-
Notifications
You must be signed in to change notification settings - Fork 324
Pipe model rework #4283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
screret
wants to merge
30
commits into
GregTechCEu:1.20.1
Choose a base branch
from
screret:sc/pipe-model-rework
base: 1.20.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pipe model rework #4283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NO MORE LDLIB RENDERERS!!!
* Add RegisterDynamicResourcesEvent * move dynamic asset init to event listener * remove unused imports * Move pipe model reinit to an event listener * add event listeners * change variable name in example * Copy the workflow into here * Add setup build step * Apply spotless formatting --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e instead of block entity
also add a way to create pipe models with datagen for blocks that aren't generated at runtime (I misclicked this into this commit, was supposed to be separate, oops)
…ntities, use the actual constructor instead
… (so PipeModelBuilder can create the restrictor models by itself)
…RuntimeBlockstateProvider
…ction cache (so it can be cleared manually)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.20.1
Release: Major - 0.X.0
Releases focused on Content, changes to gameplay; While maintaining mostly API stability.
type: refactor
Suggestion to refactor a section of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
No more LDLib renderers. anywhere.
Implementation Details
a system similar to the machine models but much simpler.
Outcome
maybe more fps?
less reliance on ldlib
Additional Information
I also made lamps not use ldlib renderers while at it
untested because this laptop cant launch the game well enough I hope it works
Potential Compatibility Issues
anyone with custom pipe implementations will have to tweak their code very slightly (see example below)