Skip to content

Multiblock Refactor#3119

Draft
YoungOnionMC wants to merge 96 commits into
mui2-refactorfrom
yo/the-patterning
Draft

Multiblock Refactor#3119
YoungOnionMC wants to merge 96 commits into
mui2-refactorfrom
yo/the-patterning

Conversation

@YoungOnionMC
Copy link
Copy Markdown
Member

@YoungOnionMC YoungOnionMC commented Apr 30, 2025

What

Multiblock refactor, TBD

TODO

  • predicate error highlighting
  • data fixer for front facing/upwards facing
  • figure out why predicate testing for global cache does not work(heat proof casing minimum is wrong)
  • anchor point definition for substructures
  • fix autobuild predicate testing to actual include a block entity for rotation
  • give charcoal pile ignitor a expandable pattern
  • add autobuilding for expandable patterns
  • move more structure defs to using the frame predicate(miners/fluid drills)
  • layer limits do not work with the autobuilder
  • arbitrary pattern checking for abstract collection of blocks
  • terminal block queueing
  • aisle groups for repeatability
  • remove async and only recheck on state changed
  • predicate storage in multiblock definition for easy addon editing
  • predicate on-succeed runner

… into yo/the-patterning

# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/block/MetaMachineBlock.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/MultiblockMachineDefinition.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/MultiblockControllerMachine.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/WorkableMultiblockMachine.java
#	src/main/java/com/gregtechceu/gtceu/api/multiblock/Predicates.java
#	src/main/java/com/gregtechceu/gtceu/api/multiblock/predicates/SimplePredicate.java
#	src/main/java/com/gregtechceu/gtceu/api/pattern/BlockPattern.java
#	src/main/java/com/gregtechceu/gtceu/api/pattern/FactoryBlockPattern.java
#	src/main/java/com/gregtechceu/gtceu/api/pattern/MultiblockState.java
#	src/main/java/com/gregtechceu/gtceu/api/pattern/util/RelativeDirection.java
#	src/main/java/com/gregtechceu/gtceu/client/model/WorkableOverlayModel.java
#	src/main/java/com/gregtechceu/gtceu/common/data/machines/GTMultiMachines.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/ActiveTransformerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/AssemblyLineMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/CleanroomMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/FusionReactorMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/LargeMinerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/PowerSubstationMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/DataBankMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/HPCAMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/ResearchStationMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/steam/SteamParallelMultiblockMachine.java
#	src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java
YoungOnionMC and others added 16 commits May 17, 2026 18:51
…sync stuff (#4848)

Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/cover/CoverBehavior.java
#	src/main/java/com/gregtechceu/gtceu/api/machine/trait/RecipeLogic.java
#	src/main/java/com/gregtechceu/gtceu/api/sync_system/SyncDataHolder.java
#	src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/ValueTransformer.java
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/block/MetaMachineBlock.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/electric/BlockBreakerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/electric/ItemCollectorMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/electric/research/HPCAMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/ItemBusPartMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/steam/LargeBoilerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/steam/SteamMinerMachine.java
YoungOnionMC and others added 13 commits May 19, 2026 01:28
…ting, get rid of block pos cache in pattern state
…rning

# Conflicts:
#	src/generated/resources/assets/gtceu/lang/en_ud.json
#	src/generated/resources/assets/gtceu/lang/en_us.json
#	src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/cover/ItemFilterCover.java
#	src/main/java/com/gregtechceu/gtceu/common/cover/PumpCover.java
#	src/main/java/com/gregtechceu/gtceu/common/cover/RobotArmCover.java
#	src/main/java/com/gregtechceu/gtceu/common/cover/detector/DetectorCover.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/mui/TestMuiMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/mui/GTMuiWidgets.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Admin Merge Requires Specialized Merge Permissions -Ask Org Admin to merge Do Not Merge DO NOT MERGE THIS PR YET! Release: API - X.0.0 Major Breaking Refactors that MUST be in a API-Breaking Release Tests: Failed Game Tests have failed on this PR type: refactor Suggestion to refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fluid miner multiblock doesn't allow framed cables/pipes

6 participants