Flipped negative y face of multiside blocks#126
Open
ICaxapI wants to merge 1 commit intoGregTech6:masterfrom
Open
Flipped negative y face of multiside blocks#126ICaxapI wants to merge 1 commit intoGregTech6:masterfrom
ICaxapI wants to merge 1 commit intoGregTech6:masterfrom
Conversation
Author
Member
|
How does this affect Bottom Facing Sensor Blocks? Because if it messes those up, I would be forced to rewrite a ton of geometric code, which needs way too much trial and error for me. |
Author
Member
|
the reason i never fixed this is because the UVs somehow have a different effect on full blocks vs nonfull blocks. That is one of the other reasons. |
Author
Author
|
Overall, if we have more groups of textures that need to be added to the "whitelist", we can make it a separate function with a collection that we will compare with, and put this list somewhere in gregapi.data.CS, judging by similar checks in the project. |
Author
|
I hope I correctly understood the project's philosophy regarding storing utils functions and static data. |
Introduced a utility method to determine if textures need flipping based on texture groups and block bounds. Updated rendering functions to use this logic, ensuring correct texture orientation for specific cases. Corrected UV coordinates for the negative y face rendering. These changes ensure proper texture alignment for bottom sides when using ambient occlusion (AO) and regular rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Corrected UV coordinates for the negative y face rendering. These changes ensure proper texture alignment for bottom sides when using ambient occlusion (AO) and regular rendering.