refactor: remove redundant TestContainers BOM from openespi-common #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring Boot 3.5 dependency management already includes TestContainers BOM, making the explicit version declaration redundant. Verified with MySQL and PostgreSQL integration tests - all 21 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The sonar-maven-plugin was only defined in <pluginManagement> but not in the active <plugins> section, causing CI/CD failures when running mvn sonar:sonar. Maven requires plugins to be in the active <plugins> section to be executable via the prefix:goal syntax. Fixes SonarCloud Analysis and SonarCloud PR Analysis CI/CD failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Maven's plugin prefix resolver doesn't recognize 'sonar' prefix by default. Changed from 'mvn sonar:sonar' to 'mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar' in both CI/CD and PR checks workflows. This ensures the plugin can be resolved without requiring additional Maven settings.xml configuration for plugin groups. Fixes "No plugin found for prefix 'sonar'" CI/CD error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes redundant TestContainers BOM declaration from
openespi-common/pom.xml. Spring Boot 3.5's dependency management already includes TestContainers BOM, making the explicit version declaration unnecessary.Changes
testcontainers.versionproperty (1.20.1)dependencyManagementsection with TestContainers BOM importTesting
✅ All integration tests pass:
Impact
Verification
Tested with:
🤖 Generated with Claude Code