Fix cursor handling in ClusterEventService#26089
Open
moesterheld wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ClusterEventServiceopened a cursor withTailableAwait, causing it to always stay in thecursor.hasNext()while loop initerateEvents.This replaces the loop condition with
isRunning(). ThetryNext()is sufficient as it will already null if no data is returned withinmaxAwaitTime. To make sure this is will not delay server shutdownmaxAwaitTimeis now set to 1s./nocl
Motivation and Context
fixes #25878
How Has This Been Tested?
adjusted unit tests
Screenshots (if appropriate):
Types of changes
Checklist: