Slicing intermediate changes for stepwise improvements#25363
Slicing intermediate changes for stepwise improvements#25363
Conversation
| void scrollEvents(String queryString, TimeRange timeRange, Set<String> affectedIndices, Set<String> streams, | ||
| List<UsedSearchFilter> filters, int batchSize, ScrollEventsCallback resultCallback) throws EventProcessorException; | ||
|
|
||
| Map<String, Long> aggregateSlices(String queryString, TimeRange timerange, Set<String> affectedIndices, |
There was a problem hiding this comment.
It is up to you to decide, but for me, "slices" wording seems a lot like FE-wording, and I would rather avoid it in Indexer-access methods, trying to use more general aggregate/grouping/bucketing naming.
There was a problem hiding this comment.
Let's keep it for now
| Set<String> eventStreams, String filterString, Set<String> forbiddenSourceStreams, | ||
| Map<String, Set<String>> extraFilters, String slicingColumn, int maxBuckets); | ||
|
|
||
| Map<String, Long> aggregateRangeSlices(String queryString, TimeRange timerange, Set<String> affectedIndices, |
There was a problem hiding this comment.
I also have a feeling this methods are not in a proper class...
MoreSearchAdapter feels like an adapter for scrolling and chunking, and those methods intentionally return 0 results and just provide aggregations results.
If you agree to move it elsewhere, I am fine with doing it in a separate PR.
There was a problem hiding this comment.
The MoreSearch Adapter is in the Events package. So all this is Events based. Currently, I'm only slicing in that area. So let's keep it for now.
luk-kaminski
left a comment
luk-kaminski
left a comment
There was a problem hiding this comment.
It has been decided we can merge and polish the code in the follow-up PRs.
3 participants
Description
Motivation and Context
Part 1 of a series of improvements for the slicing feature
/nocl unreleased feature
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/13558
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: