Avoid scroll-to hint being shown for query input on page load. (7.0)#25362
Open
graylog-internal-actions-access[bot] wants to merge 1 commit into7.0from
Open
Avoid scroll-to hint being shown for query input on page load. (7.0)#25362graylog-internal-actions-access[bot] wants to merge 1 commit into7.0from
7.0)#25362graylog-internal-actions-access[bot] wants to merge 1 commit into7.0from
Conversation
* Avoid scroll-to hint being shown for query input on page load. * Prevent ScrollToHint from creating unwanted gap in SearchBarContainer. Position the scroll target div absolutely so it does not participate in the flex layout and avoids triggering the row-gap. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Pulling up one level, removing styles. * Applying same fix for dashboard search bar. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit e0f7ba0)
graylog-internal-actions-access
bot
requested review from
linuspahl and
maxiadlovskii
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #25346 to
7.0.Note: This needs a backport to
7.0.Description
Motivation and Context
This PR is a follow-up to #25257, which fixed the visibility check for the "Scroll to"-hint. Unfortunately, this triggers the hint being shown on page load, when a deep-link to a saved search, dashboard or new search/dashboard is used. This happens, because the parent element of the hint component in the search/dashboard query input is the
bodyelement.This PR is fixing this, by moving the
ScrollToHintcomponent inside the search query controls container, so this element is used for visibility checks./nocl Fixing unreleased change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: