Remove no longer needed offset and width calculation for bars in bar chart. #22792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
changed the title
linuspahl
changed the title
maxiadlovskii
approved these changes
Jun 5, 2025
maxiadlovskii
pushed a commit
that referenced
this pull request
Jun 5, 2025
dennisoelkers
pushed a commit
that referenced
this pull request
Jun 6, 2025
9 tasks
linuspahl
added a commit
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note, this PR needs a backport for
6.2and6.1. (both versions implement the required plotly version)Description
Motivation and Context
Due to a plotly update (related change: plotly/plotly.js#7009) we no longer have to calculate the width and offset bars in the bar chart manually (Thank you for finding this @maxiadlovskii).
This is improving the bars width in some scenarios, like the one described in #22163.
Fixes #22163
/nocl