Fix syncing issue with Font selector#1605
Closed
jakejackson1 wants to merge 2 commits intohot-patchfrom
Closed
Conversation
(cherry picked from commit a3961c1)
jakejackson1
force-pushed
the
font-select-sync
branch
from
fb97cac to
d8f22af
Compare
Member
Author
|
Resolved in #1641 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dependency update branch surfaced a couple of long-running issues with the Font Manager + Font Dropdown sync feature.
This PR ensures the Font Dropdown actually stays in sync with the Font Manager, and will be auto-updated if a template adds fonts when installed in the Template Manager.
Also fix up two translation issues.
Testing instructions
@todo. Need to update Jest test.
Screenshots
Checklist:
Additional Comments