Skip to content

Add support for opening multiple selected files from disk#4128

Open
Keavon wants to merge 1 commit intomasterfrom
multi-doc-open
Open

Add support for opening multiple selected files from disk#4128
Keavon wants to merge 1 commit intomasterfrom
multi-doc-open

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented May 8, 2026

Finally, it's not so laborious to, one-by-one, open and re-save all the demo artwork every time we need to do that.

Also stabilizes the HashMap/HashSet serde serialization so the JSON doesn't reorder on every save.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for selecting multiple files in both the desktop and web frontends. It also implements deterministic serialization for HashMaps and HashSets by sorting their entries before serialization, which reduces unnecessary churn in saved-document diffs. A review comment suggests refactoring the file-picking logic in app.rs to eliminate code duplication and ensure consistent error logging across single and multiple file selection paths.

Comment thread desktop/src/app.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant