Add support for opening multiple selected files from disk#4128
Open
Add support for opening multiple selected files from disk#4128
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for selecting multiple files in both the desktop and web frontends. It also implements deterministic serialization for HashMaps and HashSets by sorting their entries before serialization, which reduces unnecessary churn in saved-document diffs. A review comment suggests refactoring the file-picking logic in app.rs to eliminate code duplication and ensure consistent error logging across single and multiple file selection paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally, it's not so laborious to, one-by-one, open and re-save all the demo artwork every time we need to do that.
Also stabilizes the HashMap/HashSet serde serialization so the JSON doesn't reorder on every save.