Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the max_aabb_inflation method to include a path_is_closed parameter, ensuring that stroke alignment is correctly handled for open versus closed paths during bounding box calculations. The feedback identifies a performance optimization opportunity in renderer.rs where path traversal and stroke cloning can be minimized by caching the stroke and short-circuiting the closed-path check when the stroke is centered or non-renderable.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/libraries/rendering/src/renderer.rs">
<violation number="1" location="node-graph/libraries/rendering/src/renderer.rs:253">
P1: Clip/layer inflation uses column-length min/max, which is not conservative under shear and can still crop strokes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug occurs in Vello when a non-default alpha blending setting is used like an opacity <100%. The render bounds given to Vello were incorrect when the path is open and the stroke align (which isn't valid for open paths) is set to Inside.
Vello (before):
SVG (unchanged) and Vello (after):