Harden release scripts: fix metadata parsing, passphrase scoping, and path safety#110
Open
thomasbuilds wants to merge 5 commits intoGrapheneOS:16-qpr2from
Open
Harden release scripts: fix metadata parsing, passphrase scoping, and path safety#110thomasbuilds wants to merge 5 commits intoGrapheneOS:16-qpr2from
thomasbuilds wants to merge 5 commits intoGrapheneOS:16-qpr2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
generate-metadataOTA metadata parsingsplit("=")withpartition("="), which handles build fingerprints and other values that contain=.post-build-incrementaldirectly instead of indexing intopost-build; add required-field validation forpost-build-incremental,post-timestamp, andpre-device.Add strict shell failure handling to
generate-keyserrexit,nounset, andpipefail.Avoid exporting key passphrases broadly
decrypt-keysandencrypt-keysscope passphrase variables to the specificopensslinvocations that need them viaenv "password=..." openssl ...; also fixcd $1→cd "$1"and array/filename quoting in the key loops.generate-release.shandgenerate-delta.shstrip inherited passphrase export state, pass it only todecrypt-keys, then unset it.generate-releases.shandgenerate-deltas.shno longer export the passphrase for their whole shell process.Quote release output paths in
generate-release.sh$RELEASE_OUTinrm -rf,mkdir,unzip -d, andcd.$TARGET_FILES_INPUTwhen extractingOTA/android-info.txt.Remove unused
AVB_PKMDassignment fromgenerate-release.sh