Skip to content

Bump eslint from 9.39.4 to 10.4.0#655

Open
ggtlvkma356 wants to merge 3 commits into
GrapheneOS:mainfrom
ggtlvkma356:npm_and_yarn/main/eslint-10.3.0
Open

Bump eslint from 9.39.4 to 10.4.0#655
ggtlvkma356 wants to merge 3 commits into
GrapheneOS:mainfrom
ggtlvkma356:npm_and_yarn/main/eslint-10.3.0

Conversation

@ggtlvkma356
Copy link
Copy Markdown
Contributor

@ggtlvkma356 ggtlvkma356 commented May 15, 2026

Supersede #638, #656.

Dependencies to @eslint/js was removed from eslint. See eslint/eslint#20539.

@ggtlvkma356 ggtlvkma356 changed the title Npm and yarn/main/eslint 10.3.0 Bump eslint from 9.39.4 to 10.3.0 May 15, 2026
Copy link
Copy Markdown
Member

@inthewaves inthewaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update README.md as it says Node.js 20+, but they removed support for Node.js < v20.19: https://eslint.org/docs/latest/use/migrate-to-10.0.0#drop-old-node

ESLint is officially dropping support for these versions of Node.js starting with ESLint v10.0.0. ESLint now supports the following versions of Node.js:

  • Node.js v20.19.0 and above
  • Node.js v22.13.0 and above
  • Node.js v24 and above

To address: Make sure you upgrade to at least Node.js v20.19.0 when using ESLint v10.0.0.

@inthewaves
Copy link
Copy Markdown
Member

Actually pdfjs seems to want higher Node.js too (though haven't seen issues)l, this is from the CI run

> Task :app:npmSetup
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'pdfjs-dist@5.7.284',
npm warn EBADENGINE   required: { node: '>=22.13.0 || >=24' },
npm warn EBADENGINE   current: { node: 'v20.20.2', npm: '10.8.2' }
npm warn EBADENGINE }

@ggtlvkma356
Copy link
Copy Markdown
Contributor Author

Actually pdfjs seems to want higher Node.js too (though haven't seen issues)l, this is from the CI run

> Task :app:npmSetup
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'pdfjs-dist@5.7.284',
npm warn EBADENGINE   required: { node: '>=22.13.0 || >=24' },
npm warn EBADENGINE   current: { node: 'v20.20.2', npm: '10.8.2' }
npm warn EBADENGINE }

That is likely because of the default version used by setup-node. I can change the workflow to use a higher version.

@ggtlvkma356 ggtlvkma356 changed the title Bump eslint from 9.39.4 to 10.3.0 Bump eslint from 9.39.4 to 10.4.0 May 18, 2026
@ggtlvkma356
Copy link
Copy Markdown
Contributor Author

I have made CI use node 22. Also upgraded eslint to 10.4.0, which doesn't have extra changes needed.

Also specify node version in workflows
@ggtlvkma356 ggtlvkma356 force-pushed the npm_and_yarn/main/eslint-10.3.0 branch from 91cb9dd to a70a767 Compare May 18, 2026 13:55
Copy link
Copy Markdown
Member

@inthewaves inthewaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed and works locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants