Do not reserve space for an icon in settings list#395
Do not reserve space for an icon in settings list#395t895 wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
There is no icon in this list so it does not need the reserved space
|
This is the intended behavior according to https://issuetracker.google.com/issues/119882818. Google's apps (e.g. Contacts) have this extra margin too. |
|
Many other Google apps don't have the extra margin, not clear if they use the androidx preference library. |
|
Also, default release channel setting doesn't have the app:iconSpaceReserved attribute. Adding it manually to all preferences seems wrong. |
I know they have this extra margin in Google apps, but that doesn't take away from it being a very outdated look. Although I guess this highlights the larger issue of how androidx preference doesn't use up-to-date material 3 components. Are you thinking that we just keep this as-is until we can replace it with a more modern look?
That's fair, I could see if I could make this a default. |
df82e3a to
def62e0
Compare
8df4f03 to
9488f6b
Compare
There is no icon in this list so it does not need the reserved space
Before:

After:
