Move files into core subdir; extract fidelity bounds logic #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does two things: first, it moves the files defining the core functions for the three (so far) phenomena investigated--namely state transfer between vertices/pairs of vertices, uniform mixing, and fractional revival--into a core subdirectory of src so that they are not mixed up with the more 'fundamental' files like types.jl, utils.jl, etc. Second, it extracts the logic for bounding the state transfer fidelity function's derivatives (both first and second) from the state transfer file to utils.jl. This is both a separation-of-concerns choice and a desire to reuse the bounds for uniform mixing and fractional revival implementations.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does two things: first, it moves the files defining the core functions for the three (so far) phenomena investigated--namely state transfer between vertices/pairs of vertices, uniform mixing, and fractional revival--into a core subdirectory of src so that they are not mixed up with the more 'fundamental' files like types.jl, utils.jl, etc.
Second, it extracts the logic for bounding the state transfer fidelity function's derivatives (both first and second) from the state transfer file to utils.jl. This is both a separation-of-concerns choice and a desire to reuse the bounds for uniform mixing and fractional revival implementations.