fix(#3273): keep Side Menu Group open by bdfranck · Pull Request #3422 · GovAlta/ui-components

bdfranck · 2026-02-12T19:17:44Z

Before

When a parent Side Menu Group is current and open,
But a child Group is not current or open,
The parent group will be closed.

After

When a parent Side Menu Group is current and open,
But a child Side Menu Group is not current or open,
The parent Group is still current and open.

Copilot

Pull request overview

Fixes nested goa-side-menu-group state propagation so a parent group that is already current/open is not incorrectly closed when a child group reports itself as non-current. This aligns Side Menu Group open behavior with expected navigation highlighting.

Changes:

Update the child _open event handler to only promote parent _current/_open when the child is current (and not overwrite parent state when the child is not current).

Copilot · 2026-02-13T18:51:18Z

@bdfranck I've opened a new pull request, #3426, to work on those changes. Once the pull request is ready, I'll request review from you.

netlify · 2026-02-18T22:21:18Z

✅ Deploy Preview for goa-design-2 ready!

Name	Link
🔨 Latest commit	`4d417ec`
🔍 Latest deploy log	https://app.netlify.com/projects/goa-design-2/deploys/69a9ed59d9fdf10008e0e44b
😎 Deploy Preview	https://deploy-preview-3422--goa-design-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

willcodeforcoffee

It seems to be working correctly now. LGTM 👍

ArakTaiRoth · 2026-02-23T21:26:43Z

@chrisolsen This is good to be merged

chrisolsen · 2026-02-24T20:36:57Z

    // listen to events by children (if child is open the parent also has to be open)
    _rootEl.addEventListener("_open", (e: Event) => {
-      _open = _current = (e as CustomEvent).detail.current;
+      if ((e as CustomEvent).detail.current) _current = _open = true;


Is there a reason that this change was made. It seems to do the same thing...am I missing something?

Then again if we are receiving an _open event, then wouldn't we just always set _current and _open to true?

@chrisolsen Here's how the bug was happening. If we have an embedded group like the one below...

<GoabSideMenu> <GoabSideMenuGroup heading="Parent Group"> <Link to="/parent">Parent Link</Link> <GoabSideMenuGroup heading="Child Group"> <Link to="/child">Child Link</Link> </GoabSideMenuGroup> </GoabSideMenuGroup> </GoabSideMenu>

...the Parent Group receives two _open events. So when the Parent Link is current, the following happens oh load:

The Parent Group receives an _open event from Parent Link. The Group opens because detail.current is true.

The Parent Group receives an _open event from the Child Link. The Group closes again because detail.current is false.

But we never need to close a group because it's closed by default. My change only opens a group if details.current is true. It does nothing when it is false.

Is there a better way to address this? Have I neglected to consider other scenarios? I'm happy to chat about it if you have further questions.

chrisolsen · 2026-03-05T01:39:38Z

Just waiting for changes that were discussed

bdfranck · 2026-03-05T15:47:14Z

@chrisolsen I amended my commit with the following changes:

Added a _senderEl outside the _rootEl
Changed events to dispatch from _senderEl

This reduced the number of events received but doesn't appear to fix the problem. I still think there's an issue with this function:

ui-components/libs/web-components/src/components/side-menu-group/SideMenuGroup.svelte

Lines 79 to 83 in 00a015d

    
               // listen to events by children (if child is open the parent also has to be open) 
        
               _rootEl.addEventListener("_open", (e: Event) => { 
        
                 _open = _current = (e as CustomEvent).detail.current; 
        
               }); 
        
             }

I currently does the following...

Open the parent group if the child group is open.
Close the parent group if the child group is closed.

But I think it should do the following:

Open the parent group if the child group is open.
Close the parent group if the child group is closed AND the parent does not have a current menu item.

Does that make sense? It's possible I don't understand the broader Side Menu event ecosystem.

chrisolsen · 2026-03-05T17:45:24Z

@bdfranck let's chat about this later today.

bdfranck · 2026-03-05T21:03:11Z

@chrisolsen I've amended my commit with the following changes to SideMenuGroup.svelte:

Re-named the notifyParent function to dispatchGroupOpen
Child group only dispatches _open when the group is open
Removed the current boolean from the _open event
When a parent group receives _open it always sets open to true

This has the same effect as my original change but should be much clearer.

Future enhancements that we discussed:

Further reducing redundant events
Keeping a group open when switching to a different nav item in a sibling group.

chrisolsen · 2026-03-05T21:20:43Z

@ArakTaiRoth @willcodeforcoffee changes were made, so you guys might want to test things again; at least one of you.

willcodeforcoffee

✅ LGTM!

ArakTaiRoth · 2026-03-06T01:06:41Z

@chrisolsen This is good to be merged again

chrisolsen · 2026-03-06T16:29:47Z

🎉 This PR is included in version 1.41.0-dev.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-06T16:30:11Z

🎉 This PR is included in version 6.11.0-dev.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-07T15:44:58Z

🎉 This PR is included in version 4.11.0-dev.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-07T16:12:11Z

🎉 This PR is included in version 1.11.0-dev.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:23:38Z

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:32:02Z

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:40:27Z

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-03-31T23:49:06Z

🎉 This PR is included in version 5.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:32:32Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:40:56Z

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen · 2026-04-01T00:49:18Z

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

bdfranck requested a review from Copilot February 12, 2026 19:18

Copilot started reviewing on behalf of bdfranck February 12, 2026 19:19 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

bdfranck force-pushed the benji/3273-side-menu-group-stays-open branch from 2d79615 to 5f23457 Compare February 13, 2026 17:53

Copilot AI mentioned this pull request Feb 13, 2026

test(#3273): add browser test for Side Menu Group current state propagation #3426

Closed

3 tasks

GovAlta deleted a comment from Copilot AI Feb 13, 2026

bdfranck force-pushed the benji/3273-side-menu-group-stays-open branch from 5f23457 to bc6c91c Compare February 13, 2026 23:29

bdfranck linked an issue Feb 13, 2026 that may be closed by this pull request

SideMenuGroup doesn't stay open #3273

Closed

bdfranck requested a review from ArakTaiRoth February 17, 2026 16:11

ArakTaiRoth reviewed Feb 17, 2026

View reviewed changes

Comment thread apps/prs/react/src/app/app.tsx

Comment thread apps/prs/react/src/app/app.tsx

Comment thread libs/web-components/src/components/side-menu-group/SideMenuGroup.svelte Outdated

bdfranck commented Feb 17, 2026

View reviewed changes

Comment thread apps/prs/react/src/routes/bugs/bug3273.tsx

bdfranck force-pushed the benji/3273-side-menu-group-stays-open branch from bc6c91c to b43c771 Compare February 18, 2026 22:21

bdfranck force-pushed the benji/3273-side-menu-group-stays-open branch from b43c771 to 93c1c92 Compare February 18, 2026 22:22

bdfranck requested a review from ArakTaiRoth February 18, 2026 22:50

ArakTaiRoth reviewed Feb 19, 2026

View reviewed changes

Comment thread apps/prs/react/src/main.tsx Outdated

Comment thread libs/react-components/specs/side-menu.browser.spec.tsx Outdated

bdfranck force-pushed the benji/3273-side-menu-group-stays-open branch from 93c1c92 to 842c87e Compare February 19, 2026 22:37

ArakTaiRoth requested a review from willcodeforcoffee February 19, 2026 23:00

ArakTaiRoth approved these changes Feb 19, 2026

View reviewed changes

willcodeforcoffee approved these changes Feb 20, 2026

View reviewed changes

chrisolsen reviewed Feb 24, 2026

View reviewed changes

bdfranck force-pushed the benji/3273-side-menu-group-stays-open branch from 842c87e to 4511277 Compare March 5, 2026 15:33

bdfranck requested a review from chrisolsen March 5, 2026 15:33

bdfranck force-pushed the benji/3273-side-menu-group-stays-open branch from 4511277 to 53afd64 Compare March 5, 2026 15:41

fix(#3273): keep Side Menu Group open

4d417ec

bdfranck force-pushed the benji/3273-side-menu-group-stays-open branch from 53afd64 to 4d417ec Compare March 5, 2026 20:53

chrisolsen requested a review from ArakTaiRoth March 5, 2026 21:11

chrisolsen approved these changes Mar 5, 2026

View reviewed changes

chrisolsen requested a review from willcodeforcoffee March 5, 2026 21:11

willcodeforcoffee approved these changes Mar 5, 2026

View reviewed changes

chrisolsen merged commit 374dc31 into dev Mar 6, 2026
8 checks passed

chrisolsen deleted the benji/3273-side-menu-group-stays-open branch March 6, 2026 16:24

chrisolsen added the released on @dev label Mar 6, 2026

chrisolsen added the released on @next label Mar 31, 2026

chrisolsen added the released Released into production. label Apr 1, 2026

Conversation

bdfranck commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI commented Feb 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify Bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for goa-design-2 ready!

Uh oh!

Uh oh!

Uh oh!

willcodeforcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

ArakTaiRoth commented Feb 23, 2026

Uh oh!

chrisolsen Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

bdfranck Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisolsen commented Mar 5, 2026

Uh oh!

bdfranck commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisolsen commented Mar 5, 2026

Uh oh!

bdfranck commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisolsen commented Mar 5, 2026

Uh oh!

willcodeforcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

ArakTaiRoth commented Mar 6, 2026

Uh oh!

Uh oh!

chrisolsen commented Mar 6, 2026

Uh oh!

chrisolsen commented Mar 6, 2026

Uh oh!

chrisolsen commented Mar 7, 2026

Uh oh!

chrisolsen commented Mar 7, 2026

Uh oh!

chrisolsen commented Mar 31, 2026

Uh oh!

chrisolsen commented Mar 31, 2026

Uh oh!

chrisolsen commented Mar 31, 2026

Uh oh!

chrisolsen commented Mar 31, 2026

Uh oh!

chrisolsen commented Apr 1, 2026

Uh oh!

chrisolsen commented Apr 1, 2026

Uh oh!

chrisolsen commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

bdfranck commented Feb 12, 2026 •

edited

Loading

netlify Bot commented Feb 18, 2026 •

edited

Loading

bdfranck Feb 24, 2026 •

edited

Loading

bdfranck commented Mar 5, 2026 •

edited

Loading

bdfranck commented Mar 5, 2026 •

edited

Loading