feat: golang: bump version of Golang#112
Merged
Merged
Conversation
Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
Snippet bumped GOLANG_VERSION but generated Dockerfile wasn't refreshed, failing the Verify Generated Dockerfiles CI check. Co-authored-by: Claude <noreply@anthropic.com>
6 tasks
GordonBeeming
added a commit
that referenced
this pull request
May 21, 2026
* ci: auto-regenerate Dockerfiles on PRs Adds two GitHub Actions workflows that react when a PR changes docker/snippets/, docker/images.json, or docker/generate-dockerfiles.ps1: * regen-dockerfiles-push.yml — same-repo PRs only. Regenerates the Dockerfiles and pushes the result back to the PR branch. Permission scope: `contents: write`. * regen-dockerfiles-comment.yml — fork PRs only. Runs the base branch's trusted generator against the head's snippet data (never executes head code), detects drift, and posts a comment telling the contributor what to run. Refuses entirely if the PR modifies generate-dockerfiles.ps1. Permission scope: `contents: read` + `pull-requests: write`. The existing verify-generated-dockerfiles job in publish.yml stays as the hard CI gate — these workflows are the auto-fixer / nudge layered on top, so PRs like #112 (golang bump without regen) self-heal instead of needing a maintainer to push the regen commit manually. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com> * fix(ci): detect untracked Dockerfiles and avoid spam comments Address PR review feedback from Codex and Copilot: * git diff --quiet ignored untracked files, so a new image entry in images.json would generate a brand-new docker/generated/Dockerfile.* that the drift check would miss — "No drift" would fire, the new file would never get committed (push workflow) or surfaced (comment workflow), and the existing verify-generated-dockerfiles job would fail without explanation. Switch both workflows to `git status --porcelain -- docker/generated`, which catches modified, deleted, and untracked entries in one shot. The comment workflow also appends a "Untracked new generated files" section to the diff stat so contributors see exactly what's new. * The fork-comment workflow posted a fresh PR comment on every synchronize event, which would spam long-running PRs. Introduce .github/scripts/sticky-pr-comment.sh — a 30-line helper that finds a prior bot comment by HTML marker and PATCHes it in place, creating a new one only when none exists. Both comment paths (drift and generator-changed) now use it with the same marker so the same comment is recycled. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Small pull request to bump the version of Golang to the latest.