fix metadata backfill for playlist tracks after hasMetadata is set#195
Closed
appleflyerv3 wants to merge 1 commit intoGoogolplexed0:new-hierarchyfrom
Closed
fix metadata backfill for playlist tracks after hasMetadata is set#195appleflyerv3 wants to merge 1 commit intoGoogolplexed0:new-hierarchyfrom
appleflyerv3 wants to merge 1 commit intoGoogolplexed0:new-hierarchyfrom
Conversation
playlist track objects could get hasMetadata=True as soon as the track name was set, which prevented later metadata filling from filling missing fields. instead, allow later metadata parses, including fetch_extra_metadata, to populate fields that are still None. this fixes missing album track numbers when downloading tracks from playlists.
Author
|
honestly idk why this issue was happening, it was fine in previous commits |
Author
|
ah yes this addresses issue #193 too |
Owner
|
Thank you for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playlist track objects could get hasMetadata=True as soon as the track name was set, which prevented later metadata filling from filling missing fields.
instead, allow later metadata parses, including fetch_extra_metadata, to populate fields that are still None. this fixes missing album track numbers when downloading tracks from playlists.