Skip to content

Conversation

@TvdW
Copy link

@TvdW TvdW commented Jan 21, 2026

PR #469 added this and added a default, which breaks container_structure_test on ARM.

Let's remove the default so that we can choose whether we want to set a platform, restoring original behavior.

Fixes #542

PR GoogleContainerTools#469 added this and added a default, which breaks
container_structure_test on ARM.

Let's remove the default so that we can choose whether we want to set a
platform, restoring original behavior.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @TvdW, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build failure on ARM architectures by modifying the container_structure_test Bazel rule. It removes the default "linux/amd64" value from the platform attribute, which was inadvertently causing issues on non-AMD64 systems. This change restores the flexibility for users to specify the platform when needed, or allow it to be determined automatically, thereby fixing the breakage introduced by a previous PR.

Highlights

  • Platform attribute default removal: The default value of "linux/amd64" has been removed from the platform attribute in bazel/container_structure_test.bzl, making the platform specification optional.
  • ARM build fix: This change resolves an issue where container_structure_test was breaking on ARM architectures due to the previously hardcoded default platform, restoring the original flexible behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the hardcoded linux/amd64 default for the platform attribute in the container_structure_test Bazel rule. This change fixes an issue for users on non-amd64 architectures like ARM by allowing the underlying container-structure-test tool to use its own architecture-aware default. I've added a suggestion to improve the documentation for this attribute to make the default behavior clearer to users.

"platform": attr.string(
default = "linux/amd64",
doc = "Set platform if host is multi-platform capable (default \"linux/amd64\")",
doc = "Set platform if host is multi-platform capable",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve clarity for users of this rule, it would be helpful to mention what the default behavior is when platform is not specified. The underlying container-structure-test tool defaults to the host's architecture (linux/GOARCH), so mentioning examples for different architectures would be beneficial.

Suggested change
doc = "Set platform if host is multi-platform capable",
doc = "Set platform if host is multi-platform capable. If not set, it defaults to the host's platform, e.g., 'linux/amd64' or 'linux/arm64'."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

platform attribute is required for non-amd64 users

1 participant