Upgrading angular version to 20#1282
Open
pratickchokhani wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
Upgrading angular version to 20#1282pratickchokhani wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
pratickchokhani wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
0715376 to
044a31c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1282 +/- ##
=======================================
Coverage 47.45% 47.46%
=======================================
Files 234 234
Lines 26932 26932
Branches 599 599
=======================================
+ Hits 12780 12782 +2
+ Misses 13417 13415 -2
Partials 735 735
🚀 New features to boost your workflow:
|
813e4e6 to
4c47c14
Compare
4c47c14 to
8c4f48b
Compare
Contributor
shreyakhajanchi
left a comment
There was a problem hiding this comment.
Can you please add the test details in the description?
Contributor
Author
Have added it in the comments. |
Contributor
shreyakhajanchi
left a comment
There was a problem hiding this comment.
The PR looks fine, just verify the airlock compatibility: https://g3doc.corp.google.com/third_party/harbourbridge/g3doc/operations/ui_package_update_process.md?cl=head
And also check if any changes are required in the release script in git-on-borg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested the UI flows in both mac and glinux:
https://screenshot.googleplex.com/C8F6TSv2EQxTHK5
https://screenshot.googleplex.com/KczzbaexHwupQ4F