Skip to content

Upgrading angular version to 20#1282

Open
pratickchokhani wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
pratickchokhani:angular-upgrade-v20
Open

Upgrading angular version to 20#1282
pratickchokhani wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
pratickchokhani:angular-upgrade-v20

Conversation

@pratickchokhani
Copy link
Copy Markdown
Contributor

@pratickchokhani pratickchokhani commented Mar 5, 2026

@pratickchokhani pratickchokhani force-pushed the angular-upgrade-v20 branch 3 times, most recently from 0715376 to 044a31c Compare March 5, 2026 09:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.46%. Comparing base (ec11adf) to head (8c4f48b).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1282   +/-   ##
=======================================
  Coverage   47.45%   47.46%           
=======================================
  Files         234      234           
  Lines       26932    26932           
  Branches      599      599           
=======================================
+ Hits        12780    12782    +2     
+ Misses      13417    13415    -2     
  Partials      735      735           
Components Coverage Δ
backend-apis 42.60% <ø> (ø)
backend-library 51.83% <ø> (ø)
cli 24.44% <ø> (ø)
frontend 38.68% <ø> (+0.04%) ⬆️
Files with missing lines Coverage Δ
ui/src/app/app.component.ts 50.00% <ø> (ø)
...ponents/add-index-form/add-index-form.component.ts 97.91% <ø> (ø)
...ponents/add-new-column/add-new-column.component.ts 70.73% <ø> (ø)
...nts/add-new-sequence/add-new-sequence.component.ts 92.85% <ø> (ø)
...-primary-key/add-shard-id-primary-key.component.ts 41.37% <ø> (ø)
...dialog/bulk-drop-restore-table-dialog.component.ts 63.15% <ø> (ø)
...-profile-form/connection-profile-form.component.ts 34.21% <ø> (ø)
...nents/database-loader/database-loader.component.ts 66.66% <ø> (ø)
...omponents/dataflow-form/dataflow-form.component.ts 100.00% <ø> (ø)
...s/direct-connection/direct-connection.component.ts 37.83% <ø> (ø)
... and 33 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pratickchokhani pratickchokhani force-pushed the angular-upgrade-v20 branch 2 times, most recently from 813e4e6 to 4c47c14 Compare March 6, 2026 06:20
@pratickchokhani pratickchokhani marked this pull request as ready for review March 6, 2026 06:27
@pratickchokhani pratickchokhani requested a review from a team as a code owner March 6, 2026 06:27
@pratickchokhani pratickchokhani requested review from VardhanThigle, aasthabharill and shreyakhajanchi and removed request for a team March 6, 2026 06:27
Copy link
Copy Markdown
Contributor

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the test details in the description?

@pratickchokhani
Copy link
Copy Markdown
Contributor Author

Can you please add the test details in the description?

Have added it in the comments.

Copy link
Copy Markdown
Contributor

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks fine, just verify the airlock compatibility: https://g3doc.corp.google.com/third_party/harbourbridge/g3doc/operations/ui_package_update_process.md?cl=head

And also check if any changes are required in the release script in git-on-borg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants