-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat: Adding DAG parsing profiler tool #13645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding DAG parsing profiler tool #13645
Conversation
a74ffb7 to
8552eb2
Compare
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
8552eb2 to
507bff9
Compare
| @@ -0,0 +1,433 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave this first line out, should start with copyright header.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # [START composer_dag_parsing_profiler_dag] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels really long to be embedded in docs with this region tag. Are you expecting to add the full thing here based on the region tag?
|
Thanks for the work on creating this tool. We are moving away from hosting functional utilities in our managed sample repos. Sample repos are optimized for 'how-to' discovery and heavy tools here can make it harder for developers to find the snippets they need. To ensure this tool gets the right versioning and long-term support, we recommend that it lives in the dedicated repository for composer utilities https://github.com/GoogleCloudPlatform/composer-utilities. This helps users know it's a functional utility and not just a code snippet. |
Description
Adding a new DAG tool to troubleshoot and profile DAGs parsing.
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)