fix: update out of sync Prometheus image #1789
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsmatulis
changed the title
hsmatulis
force-pushed
the
hsmatulis-patch-examples
branch
2 times, most recently
from
46f589a to
06f35ed
Compare
bwplotka
reviewed
Oct 28, 2025
bwplotka
reviewed
Oct 28, 2025
bwplotka
reviewed
Oct 28, 2025
bwplotka
reviewed
Oct 28, 2025
Collaborator
There was a problem hiding this comment.
Thanks, added some comments. Also not sure if docs should link to unreleased 0.17 branch/release at the moment or should we just use main. Let's chat
Also please update commit msg, that's why conform is complaining.
FYI, have you seen #1786?
Nevertheless let's converge to something that will work for docs. I'd say .6 image with config-reloader bump and doing this on 0.15 release might be best for now (let's discuss in gchat), but I wonder if there's a room for special branch for docs or at least minimal templating for basics like config-reloader version.
hsmatulis
force-pushed
the
hsmatulis-patch-examples
branch
3 times, most recently
from
3564788 to
78bde6c
Compare
The prometheus image in the example directory should be kept in sync with the one used by the 0.17 branch Signed-off-by: Henrique Matulis <hmatulis@google.com>
hsmatulis
force-pushed
the
hsmatulis-patch-examples
branch
from
78bde6c to
0f1880e
Compare
lyanco
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prometheus image in the example directory should be kept in sync with the one used by the 0.17 branch