feat(secretmanager): Adding secret rotation samples #4218
Conversation
…odejs-docs-samples into node_list_samples
…odejs-docs-samples into node_cmek_samples
product-auto-label
bot
added
api: secretmanager
|
Here is the summary of changes. You are about to add 25 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Node.js samples for Google Cloud Secret Manager. It introduces a suite of new examples demonstrating advanced secret management capabilities, including the creation and management of secrets with Customer-Managed Encryption Keys (CMEK), expiration policies, and rotation schedules. Additionally, it provides samples for configuring Pub/Sub topics for secret notifications, managing tag bindings, and filtering secrets and their versions. A key addition is the inclusion of regional samples for all these features, offering developers practical guidance for deploying and managing secrets in specific Google Cloud regions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces new samples for managing secret rotation, expiration, CMEK, and tag bindings in Secret Manager, including regional variations. The new samples are well-structured and follow the existing patterns. However, there is a correctness issue in createSecretWithUserManagedReplicationPolicy.js where the ttl parameter, expected as a string like '900s', is directly assigned to a numeric seconds field, which will cause a runtime error. This also affects the corresponding test case. Addressing this type mismatch will ensure the samples function as intended.
| seconds: ttl, | ||
| }, |
There was a problem hiding this comment.
The ttl parameter is passed as a string (e.g., '7776000s') but the seconds field in the ttl object expects a numeric value. Directly assigning the string will lead to a type mismatch error at runtime. Please parse the ttl string to extract the numeric value for seconds.
| seconds: ttl, | |
| }, | |
| seconds: parseInt(ttl.replace('s', ''), 10), |
| const locations = ['us-east1', 'us-east5']; | ||
| const ttl = '900s'; | ||
| const output = execSync( | ||
| `node createSecretWithUserManagedReplicationPolicy.js ${parent} ${secretId}-ummr ${locations} ${ttl}` |
There was a problem hiding this comment.
The ttl parameter is passed as a string ('900s') to the createSecretWithUserManagedReplicationPolicy.js sample. As noted in the comment for that file, the sample expects a numeric value for the seconds field, which will cause a runtime error. The sample itself needs to be updated to parse this string into a number.
…odejs-docs-samples into node_expiretime_samples
…rest/nodejs-docs-samples into node_rotation_samples
1 participant
Adding secret rotation samples
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.