Skip to content

Converted BasePath references to instead use BaseUrl#17424

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:remove-direct-base-path-references
May 6, 2026
Merged

Converted BasePath references to instead use BaseUrl#17424
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:remove-direct-base-path-references

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented May 5, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 5, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5f55bbe:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 18 files changed, 63 insertions(+), 61 deletions(-)
google-beta provider View Diff 18 files changed, 63 insertions(+), 61 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
6391 5722 655 14
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
  • TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_updateVersion
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataSourceGoogleCloudRunService_basic
  • TestAccDataSourceGoogleCloudRunService_optionalProject
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample
❌ Error · Log - TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerCluster_updateVersion
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataSourceGoogleCloudRunService_basic
❌ Error · Log - TestAccDataSourceGoogleCloudRunService_optionalProject
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@melinath VCR tests complete for 5f55bbe!

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 5, 2026

This will have EAP impact; I've prepped a fix / corresponding update for after this goes through. attn @roaks3 FYI

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 5, 2026

VCR failures look unrelated.

@melinath melinath requested a review from SirGitsalot May 5, 2026 22:15
@melinath melinath added this pull request to the merge queue May 6, 2026
Merged via the queue into GoogleCloudPlatform:main with commit b99b435 May 6, 2026
22 of 23 checks passed
@melinath melinath deleted the remove-direct-base-path-references branch May 6, 2026 16:57
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants