terraform.go: add hasEligibleExample() method#17416
Merged
BBBmau merged 1 commit intoMay 6, 2026
Merged
Conversation
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 71918b5: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
shuyama1
approved these changes
May 6, 2026
gitika-yadav
pushed a commit
to gitika-yadav/magic-modules
that referenced
this pull request
May 7, 2026
inadenenko
pushed a commit
to inadenenko/magic-modules
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we do a check for an eligible example in list_resource generations. to prevent duplicate code we can move this in it's own method so that the logic can be shared across list and regular resources.
Here's the exact place in list_resource generation would use the
hasEligibleExample()method:https://github.com/GoogleCloudPlatform/magic-modules/pull/17368/changes#diff-3c988d71e717231071510844d318daa430f9a1f128117c0bb7b16f4ef0c2c44cR273-R292
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.