Added new fields ipVersion and ipCollection to secondaryIpRange in compute subnetwork resource to support secondary IPv6 ranges. by Ummulkiram2410 · Pull Request #17412 · GoogleCloudPlatform/magic-modules

Ummulkiram2410 · 2026-05-04T19:14:38Z

Adds IpVersion and IpCollection to Subnetwork resource for providing support for secondary IPv6 ranges.

Manual Testing Doc to check if the change doesn't impact existing secondary IPv4 ranges:
go/tf-secondary-ip-range-upgrade-test

compute: added `ipVersion` and `ipCollection` fields to `secondaryIpRange` field in `google_compute_subnetwork` resource

github-actions · 2026-05-08T06:12:03Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-05-11T20:37:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b343043:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 90 insertions(+), 4 deletions(-)
`google-beta` provider	View Diff	5 files changed, 444 insertions(+), 4 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 30 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1447	1349	93	5

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
TestAccComputeSubnetwork_secondaryIpv6Ranges
TestAccComputeSubnetwork_subnetworkWithSecondaryIpv6RangeExample

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpv6Ranges
❌ Error · Log	-	TestAccComputeSubnetwork_subnetworkWithSecondaryIpv6RangeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ummulkiram2410 VCR tests complete for b343043!

modular-magician · 2026-05-12T21:18:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3ef28d5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 90 insertions(+), 4 deletions(-)
`google-beta` provider	View Diff	5 files changed, 444 insertions(+), 4 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 30 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1448	1351	93	4

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
TestAccComputeSubnetwork_secondaryIpv6Ranges
TestAccComputeSubnetwork_subnetworkWithSecondaryIpv6RangeExample

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeSubnetwork_subnetworkWithSecondaryIpv6RangeExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpv6Ranges

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ummulkiram2410, @rileykarson VCR tests complete for 3ef28d5!

modular-magician · 2026-05-13T10:29:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b008252:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 225 insertions(+)
`google-beta` provider	View Diff	5 files changed, 580 insertions(+)
`terraform-google-conversion`	View Diff	3 files changed, 303 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1448	1352	93	3

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
TestAccComputeSubnetwork_secondaryIpv6Ranges

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeSubnetwork_secondaryIpv6Ranges
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ummulkiram2410, @rileykarson VCR tests complete for b008252!

modular-magician · 2026-05-13T19:51:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 67bf892:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 229 insertions(+), 2 deletions(-)
`google-beta` provider	View Diff	5 files changed, 584 insertions(+), 2 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 310 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1449	1355	93	1

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceFromTemplate_DiskForceAttach

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ummulkiram2410, @rileykarson VCR tests complete for 67bf892!

modular-magician · 2026-05-13T20:36:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b731e13:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 230 insertions(+), 3 deletions(-)
`google-beta` provider	View Diff	5 files changed, 585 insertions(+), 3 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 310 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1449	1352	93	4

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeAutoscaler_autoscalerBasicExample
TestAccComputeAutoscaler_autoscalerSingleInstanceExample
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccDataSourceGoogleComputeInstanceGroupManager

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log	✅	TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log	✅	TestAccDataSourceGoogleComputeInstanceGroupManager
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ummulkiram2410, @rileykarson VCR tests complete for b731e13!

rileykarson · 2026-05-14T16:19:26Z

@modular-magician reassign-reviewer c2thorn

melinath · 2026-05-14T17:44:17Z

/gcbrun

modular-magician · 2026-05-14T17:55:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9188282:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 240 insertions(+), 3 deletions(-)
`google-beta` provider	View Diff	5 files changed, 595 insertions(+), 3 deletions(-)
`terraform-google-conversion`	View Diff	3 files changed, 330 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1449	1319	93	37

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 37 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeAutoscaler_autoscalerBasicExample
TestAccComputeAutoscaler_autoscalerSingleInstanceExample
TestAccComputeAutoscaler_multicondition
TestAccComputeAutoscaler_scaleDownControl
TestAccComputeAutoscaler_scaleInControl
TestAccComputeAutoscaler_scaleInControlFixed
TestAccComputeAutoscaler_scalingSchedule
TestAccComputeAutoscaler_update
TestAccComputeForwardingRule_forwardingRuleBasicExample
TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
TestAccComputeForwardingRule_ip
TestAccComputeForwardingRule_networkTier
TestAccComputeForwardingRule_serviceDirectoryRegistrations
TestAccComputeForwardingRule_update
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
TestAccComputeRegionAutoscaler_scaleDownControl
TestAccComputeRegionAutoscaler_scaleInControl
TestAccComputeRegionAutoscaler_scalingSchedule
TestAccComputeRegionAutoscaler_update
TestAccComputeSubnetwork_secondaryIpv6Ranges
TestAccComputeSubnetwork_subnetworkWithSecondaryIpv6RangeExample
TestAccComputeTargetPool_update
TestAccComputeTargetPool_withSecurityPolicy
TestAccDataSourceGoogleComputeInstanceGroupManager
TestAccDataSourceGoogleComputeRegionInstanceGroupManager
TestAccDataSourceGoogleForwardingRule
TestAccDataSourceGoogleForwardingRules
TestAccInstanceGroupManager_autoHealingPolicies
TestAccInstanceGroupManager_basic
TestAccInstanceGroupManager_self_link_unique
TestAccInstanceGroupManager_stateful
TestAccInstanceGroupManager_update
TestAccInstanceGroupManager_waitForStatus
TestAccRegionInstanceGroupManager_autoHealingPolicies
TestAccRegionInstanceGroupManager_basic
TestAccRegionInstanceGroupManager_update

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log	✅	TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log	✅	TestAccComputeAutoscaler_multicondition
✅ Log	✅	TestAccComputeAutoscaler_scaleDownControl
✅ Log	✅	TestAccComputeAutoscaler_scaleInControl
✅ Log	✅	TestAccComputeAutoscaler_scaleInControlFixed
✅ Log	✅	TestAccComputeAutoscaler_scalingSchedule
✅ Log	✅	TestAccComputeAutoscaler_update
✅ Log	✅	TestAccComputeForwardingRule_forwardingRuleBasicExample
✅ Log	✅	TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
✅ Log	✅	TestAccComputeForwardingRule_networkTier
✅ Log	✅	TestAccComputeForwardingRule_serviceDirectoryRegistrations
✅ Log	✅	TestAccComputeForwardingRule_update
✅ Log	✅	TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log	✅	TestAccComputeRegionAutoscaler_scaleDownControl
✅ Log	✅	TestAccComputeRegionAutoscaler_scaleInControl
✅ Log	✅	TestAccComputeRegionAutoscaler_scalingSchedule
✅ Log	✅	TestAccComputeRegionAutoscaler_update
✅ Log	✅	TestAccComputeSubnetwork_secondaryIpv6Ranges
✅ Log	✅	TestAccComputeSubnetwork_subnetworkWithSecondaryIpv6RangeExample
✅ Log	✅	TestAccComputeTargetPool_update
✅ Log	✅	TestAccComputeTargetPool_withSecurityPolicy
✅ Log	✅	TestAccDataSourceGoogleComputeInstanceGroupManager
✅ Log	✅	TestAccDataSourceGoogleComputeRegionInstanceGroupManager
✅ Log	✅	TestAccDataSourceGoogleForwardingRule
✅ Log	✅	TestAccDataSourceGoogleForwardingRules
✅ Log	✅	TestAccInstanceGroupManager_autoHealingPolicies
✅ Log	✅	TestAccInstanceGroupManager_basic
✅ Log	✅	TestAccInstanceGroupManager_self_link_unique
✅ Log	✅	TestAccInstanceGroupManager_stateful
✅ Log	✅	TestAccInstanceGroupManager_update
✅ Log	✅	TestAccInstanceGroupManager_waitForStatus
✅ Log	✅	TestAccRegionInstanceGroupManager_autoHealingPolicies
✅ Log	✅	TestAccRegionInstanceGroupManager_basic
✅ Log	✅	TestAccRegionInstanceGroupManager_update
❌ Error · Log	-	TestAccComputeForwardingRule_ip
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ummulkiram2410, @c2thorn VCR tests complete for 9188282!

modular-magician · 2026-05-14T22:35:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6ef9339:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	6 files changed, 134 insertions(+), 3 deletions(-)
`google-beta` provider	View Diff	8 files changed, 869 insertions(+), 3 deletions(-)
`terraform-google-conversion`	View Diff	4 files changed, 168 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6433	5754	658	21

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeAutoscaler_autoscalerBasicExample
TestAccComputeAutoscaler_autoscalerSingleInstanceExample
TestAccComputeForwardingRule_ip
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataformConfig_update
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccEphemeralServiceAccountKey_create
TestAccEphemeralServiceAccountKey_upload
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
TestAccNetworkConnectivityDestination_update
TestAccNetworkConnectivityMulticloudDataTransferConfig_networkConnectivityMulticloudDataTransferConfigBasicExample
TestAccNetworkConnectivityMulticloudDataTransferConfig_update
TestAccProjectIamMemberRemove_memberInMultipleBindings
TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log	✅	TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log	✅	TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log	✅	TestAccDataformConfig_update
✅ Log	✅	TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_create
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_upload
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeForwardingRule_ip
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_update
❌ Error · Log	-	TestAccNetworkConnectivityMulticloudDataTransferConfig_networkConnectivityMulticloudDataTransferConfigBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityMulticloudDataTransferConfig_update
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ummulkiram2410, @rileykarson VCR tests complete for 6ef9339!

modular-magician · 2026-05-14T22:54:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0b9bc8a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	6 files changed, 127 insertions(+), 3 deletions(-)
`google-beta` provider	View Diff	8 files changed, 868 insertions(+), 3 deletions(-)
`terraform-google-conversion`	View Diff	4 files changed, 168 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6433	5756	658	19

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeAutoscaler_autoscalerBasicExample
TestAccComputeAutoscaler_autoscalerSingleInstanceExample
TestAccComputeForwardingRule_ip
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccEphemeralServiceAccountKey_create
TestAccEphemeralServiceAccountKey_upload
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
TestAccNetworkConnectivityDestination_update
TestAccNetworkConnectivityMulticloudDataTransferConfig_networkConnectivityMulticloudDataTransferConfigBasicExample
TestAccNetworkConnectivityMulticloudDataTransferConfig_update
TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log	✅	TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log	✅	TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_create
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_upload
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeForwardingRule_ip
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_update
❌ Error · Log	-	TestAccNetworkConnectivityMulticloudDataTransferConfig_networkConnectivityMulticloudDataTransferConfigBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityMulticloudDataTransferConfig_update
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@Ummulkiram2410, @rileykarson VCR tests complete for 0b9bc8a!

c2thorn

Two primary code change requests

c2thorn · 2026-05-14T23:58:47Z

 }
+
+{{ if eq $.ProductMetadata.Compiler "terraformgoogleconversion-codegen" }}
+// Dummy schema resource for tfplan2cai compilation


to satisfy google conversion gen, instead of stubbing this, can we just add this condition to the existing check within the customdiff function? so if the version is GA and the compiler is not google conversion

c2thorn · 2026-05-15T00:02:55Z

+}
+
+func resourceComputeSubnetworkSecondaryIpRangeCustomDiffFunc(diff tpgresource.TerraformResourceDiff) error {
+{{ if ne $.TargetVersionName `ga` -}}


Suggested change

{{ if ne $.TargetVersionName `ga` -}}

{{ if and (ne $.TargetVersionName "ga") (ne $.ProductMetadata.Compiler "terraformgoogleconversion-codegen") -}}

see https://github.com/GoogleCloudPlatform/magic-modules/pull/17412/changes#r3244979835

c2thorn · 2026-05-15T00:09:05Z

+	return resourceComputeSubnetworkSecondaryIpRangeCustomDiffFunc(diff)
+}
+
+func resourceComputeSubnetworkSecondaryIpRangeCustomDiffFunc(diff tpgresource.TerraformResourceDiff) error {


We now have two handwritten custom diff functions on the same parent field (technically three customdiffs total). For maintenance, I believe we should consider refactoring them to a single, large function so the different states and diff outcomes can be followed along within a single function vs mentally mapping them sequentially.

Maybe not for this PR as it's already large and having a large amount of testing as is.

c2thorn · 2026-05-15T00:43:45Z

 	if configValueIsEmpty && !stateValueIsEmpty {
 		log.Printf("[DEBUG] setting secondary_ip_range to newly empty")
 		diff.SetNew("secondary_ip_range", make([]interface{}, 0))
+		diff.SetNew("self_link", "send_empty_bypass")


We should not be forcing a diff here. The clientside check is something that we control in Magic Modules, and should bypass on the generator level, not on the diff level.

The generator template file lines that add the clientside check is here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/resource.go.tmpl#L855

I think the correct solution is to either add a new YAML-level flag to bypass the check, or make a new custom template that lets us change the check to whatever we want, allowing us to set a variable right here in sendSecondaryIpRangeIfEmptyDiff that gets checked during the update.

@NickElliot what do you think? We have a situation that from the result of a customDiff, secondary_ip_range is Set to New and we need the update function to run. However for some reason d.HasChange returns false here, which triggers the clientside short-circuit.

Adding a "bypass_clientside_update_check" flag feels reasonable to me, as long as the small comment line in resource.go clearly explains it should only be used for edge cases of an edge case where virtual fields flags that can be set in advance of an intended change are being used to detect explicit nulls on O+C fields.

Given how niche this scenario seems, I'm inclined to say it could be handled as a one-off for this resource but since it could come up again it might as well be a generator flag on that deletion_policy logic. In any event, Compute networks handle update calls very quickly so there is minimal downside to having it be excluded from a short circuit.

Given how niche this scenario seems, I'm inclined to say it could be handled as a one-off for this resource but since it could come up again it might as well be a generator flag on that deletion_policy logic. In any event, Compute networks handle update calls very quickly so there is minimal downside to having it be excluded from a short circuit.

Thanks for the input, we'll go with that.

c2thorn · 2026-05-15T00:44:53Z

+	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
+)
+
+func TestUnitComputeSubnetworkSecondaryIpRange_customizeDiff(t *testing.T) {


thank you for adding this

modular-magician · 2026-05-18T00:06:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4bc9a50:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	6 files changed, 131 insertions(+), 15 deletions(-)
`google-beta` provider	View Diff	8 files changed, 872 insertions(+), 15 deletions(-)
`terraform-google-conversion`	View Diff	4 files changed, 53 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6430	5757	656	17

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataformConfig_update
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccEphemeralServiceAccountKey_create
TestAccEphemeralServiceAccountKey_upload
TestAccIapWebTypeAppEngineIamMemberGenerated
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
TestAccNetworkConnectivityDestination_update
TestAccProjectIamMemberRemove_memberInMultipleBindings
TestAccPubsubSubscription_pubsubSubscriptionTagsExample
TestAccSourceRepoRepositoryIamMemberGenerated

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	❌ Error · Log	TestAccDataformConfig_update
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_upload
✅ Log	❌ Error · Log	TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccEphemeralServiceAccountKey_create
❌ Error · Log	-	TestAccIapWebTypeAppEngineIamMemberGenerated
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_update
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log	-	TestAccSourceRepoRepositoryIamMemberGenerated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Ummulkiram2410, @rileykarson, @c2thorn, @NickElliot VCR tests complete for 4bc9a50!

…leconversionnext-codegen in secondary_ip_range custom diff

modular-magician · 2026-05-18T04:10:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e3cdcce:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	6 files changed, 131 insertions(+), 15 deletions(-)
`google-beta` provider	View Diff	8 files changed, 872 insertions(+), 15 deletions(-)
`terraform-google-conversion`	View Diff	4 files changed, 53 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6430	5758	656	16

Affected Service Packages

All service packages are affected

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
TestAccCloudRunService_cloudRunServiceGpuExample
TestAccComputeInstanceFromTemplate_DiskForceAttach
TestAccContainerNodePool_withHostMaintenancePolicy
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
TestAccEphemeralServiceAccountKey_create
TestAccEphemeralServiceAccountKey_upload
TestAccIapWebTypeAppEngineIamMemberGenerated
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
TestAccNetworkConnectivityDestination_update
TestAccProjectIamMemberRemove_memberInMultipleBindings
TestAccPubsubSubscription_pubsubSubscriptionTagsExample
TestAccSourceRepoRepositoryIamMemberGenerated

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_create
✅ Log	❌ Error · Log	TestAccEphemeralServiceAccountKey_upload
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccIapWebTypeAppEngineIamMemberGenerated
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
❌ Error · Log	-	TestAccNetworkConnectivityDestination_update
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log	-	TestAccSourceRepoRepositoryIamMemberGenerated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@Ummulkiram2410, @rileykarson, @c2thorn, @NickElliot VCR tests complete for e3cdcce!

c2thorn

All review comments are addressed. I have reviewed a manual upgrade test (go/tf-secondary-ip-range-upgrade-test), and it looks good.
Failing VCR tests are not compute network related.
LGTM

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 4, 2026

Ummulkiram2410 added 6 commits May 7, 2026 17:30

WIP: Alias IPv6 secondary range support

eb3b688

Add support for secondary IPv6 ranges in Subnetworks

03a48d7

adding proper tests

fbb1b14

Resolve the build errors

9ede616

Removing trailing spaces

87059d6

Updated the test with region where the test would work

37bc4da

Ummulkiram2410 force-pushed the feat-alias-ipv6-support branch from 86cf3d3 to 37bc4da Compare May 8, 2026 04:55

Updating the code for lint error

268b107

Ummulkiram2410 changed the title ~~Feat alias ipv6 support~~ Added a new field ipVersion and ipCollection to secondaryIpRange in compute subnetwork resource to support secondary IPv6 ranges. May 8, 2026

Ummulkiram2410 added 2 commits May 8, 2026 05:18

Adding the condition to run acceptance test only in beta

af10f4a

Adding the condition to run acceptance test only in beta

b343043

Ummulkiram2410 marked this pull request as ready for review May 8, 2026 06:11

github-actions Bot requested a review from rileykarson May 8, 2026 06:12

rileykarson reviewed May 11, 2026

View reviewed changes

Comment thread mmv1/products/compute/Subnetwork.yaml

modular-magician added service/compute-vpc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 11, 2026

rileykarson reviewed May 11, 2026

View reviewed changes

Comment thread mmv1/templates/terraform/examples/subnetwork_with_secondary_ipv6_range.tf.tmpl Outdated

Comment thread mmv1/third_party/terraform/services/compute/resource_compute_subnetwork_test.go.tmpl Outdated

Comment thread mmv1/products/compute/Subnetwork.yaml

updating the test region

3ef28d5

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 12, 2026

github-actions Bot requested a review from rileykarson May 12, 2026 20:20

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 12, 2026

fix tests

b008252

Ummulkiram2410 added 2 commits May 13, 2026 10:32

fix tests

b6a680c

fix tests

352b4a1

Add cty IsNull protection to compute_subnetwork post_update

b731e13

Fix TGC nil schema panic in subnetwork custom diff

9188282

This comment was marked as outdated.

Sign in to view

rileykarson reviewed May 14, 2026

View reviewed changes

Comment thread mmv1/templates/terraform/constants/subnetwork.tmpl

Comment thread mmv1/products/compute/Subnetwork.yaml

Comment thread mmv1/products/compute/Subnetwork.yaml

github-actions Bot requested a review from c2thorn May 14, 2026 16:20

Adding unit tests for customizeDiff

6ef9339

github-actions Bot requested a review from rileykarson May 14, 2026 22:26

Fixing imports for beta

0b9bc8a

c2thorn requested changes May 15, 2026

View reviewed changes

Ummulkiram2410 added 2 commits May 17, 2026 23:13

to merge with latest changes.

055860e

Implement BypassClientsideUpdateCheck flag

4bc9a50

github-actions Bot requested review from NickElliot and c2thorn May 17, 2026 23:58

Fix TGC Next integration compilation error by excluding terraformgoog…

e3cdcce

…leconversionnext-codegen in secondary_ip_range custom diff

c2thorn approved these changes May 18, 2026

View reviewed changes

Comment thread mmv1/products/compute/Subnetwork.yaml

c2thorn added this pull request to the merge queue May 18, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 9ad49be May 18, 2026
27 of 29 checks passed

	{{ if ne $.TargetVersionName `ga` -}}
	{{ if and (ne $.TargetVersionName "ga") (ne $.ProductMetadata.Compiler "terraformgoogleconversion-codegen") -}}

Conversation

Ummulkiram2410 commented May 4, 2026 • edited by c2thorn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

modular-magician commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modular-magician commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

rileykarson commented May 14, 2026

Uh oh!

melinath commented May 14, 2026

Uh oh!

modular-magician commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

c2thorn left a comment

Choose a reason for hiding this comment

Uh oh!

c2thorn May 14, 2026

Choose a reason for hiding this comment

Ummulkiram2410 commented May 4, 2026 •

edited by c2thorn

Loading

github-actions Bot commented May 8, 2026 •

edited

Loading

modular-magician commented May 11, 2026 •

edited

Loading

modular-magician commented May 12, 2026 •

edited

Loading

modular-magician commented May 13, 2026 •

edited

Loading

modular-magician commented May 13, 2026 •

edited

Loading

modular-magician commented May 13, 2026 •

edited

Loading

modular-magician commented May 14, 2026 •

edited

Loading

modular-magician commented May 14, 2026 •

edited

Loading

modular-magician commented May 14, 2026 •

edited

Loading

NickElliot May 15, 2026 •

edited

Loading

modular-magician commented May 18, 2026 •

edited

Loading

modular-magician commented May 18, 2026 •

edited

Loading