Migrate resource_compute_target_pool.go.tmpl resource to use direct HTTP rather than a client library#17409
Draft
nsamartsev wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7f3affb: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 35 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @nsamartsev VCR tests complete for 7f3affb! |
nsamartsev
force-pushed
the
resource-compute-target-pool-migration
branch
from
7f3affb to
46fb7e9
Compare
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 46fb7e9: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 34 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @nsamartsev VCR tests complete for 46fb7e9! |
nsamartsev
force-pushed
the
resource-compute-target-pool-migration
branch
2 times, most recently
from
26cb0ca to
8c67a9b
Compare
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8c67a9b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 35 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
🟢 All tests passed! View the build log or the debug logs folder for detailed results. @nsamartsev VCR tests complete for 8c67a9b! |
WentaoNi
reviewed
May 5, 2026
WentaoNi
left a comment
WentaoNi
left a comment
There was a problem hiding this comment.
I reviewed the changes and the migration to transport_tpg.SendRequest looks correct.
However, when running TestAccComputeTargetPool_basic in VCR replay mode, I encountered a VCR mismatch error on the create (POST) request:
Error creating TargetPool: Post ".../targetPools?alt=json": Requested interaction not found
This is likely because the new implementation omits some default query parameters (like prettyPrint=false) that the old client library included and are recorded in the fixtures.
Could you please check if we need to explicitly add missing query parameters to the URL to match the fixtures?
… HTTP rather than a client library
nsamartsev
force-pushed
the
resource-compute-target-pool-migration
branch
from
8c67a9b to
49d1343
Compare
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 49d1343: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @nsamartsev VCR tests complete for 49d1343! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.