Migrate resource_compute_router_interface.go.tmpl, resource_compute_router_interface_test.go.tmpl resource to use direct HTTP rather than a client library#17407
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 49fdccf: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @nsamartsev VCR tests complete for 49fdccf! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 290adb8: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @nsamartsev VCR tests complete for 290adb8! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 14d9a1c: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @nsamartsev VCR tests complete for 14d9a1c! |
14d9a1c to
f0e115a
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f0e115a: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @nsamartsev VCR tests complete for f0e115a! |
resource_compute_router_interface.go.tmpl resource to use direct HTTP rather than a client libraryresource_compute_router_interface.go.tmpl, resource_compute_router_interface_test.go.tmpl resource to use direct HTTP rather than a client library
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
f0e115a to
5d8387a
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5d8387a: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @nsamartsev, @c2thorn VCR tests complete for 5d8387a! |
|
@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label |
5d8387a to
05b10cc
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 05b10cc: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @nsamartsev, @c2thorn VCR tests complete for 05b10cc! |
05b10cc to
fd950c1
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fd950c1: Diff reportYour PR generated the following diffs in downstream repositories:
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @nsamartsev, @c2thorn VCR tests complete for fd950c1! |
fd950c1 to
138f7a4
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 138f7a4: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @nsamartsev, @c2thorn VCR tests complete for 138f7a4! |
|
@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
138f7a4 to
3318130
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3318130: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @nsamartsev, @c2thorn VCR tests complete for 3318130! |
|
Hello @c2thorn Could you please review this PR when you have a moment? |
…irect HTTP rather than a client library
…use direct HTTP rather than a client library
3318130 to
ab4f92e
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ab4f92e: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @nsamartsev, @c2thorn VCR tests complete for ab4f92e! |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.