Skip to content

Migrate resource_compute_router_interface.go.tmpl, resource_compute_router_interface_test.go.tmpl resource to use direct HTTP rather than a client library#17407

Open
nsamartsev wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-router-interface-migration
Open

Migrate resource_compute_router_interface.go.tmpl, resource_compute_router_interface_test.go.tmpl resource to use direct HTTP rather than a client library#17407
nsamartsev wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-router-interface-migration

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrate `resource_compute_router_interface.go.tmpl` resource to use direct HTTP rather than a client library

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 49fdccf:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 107 insertions(+), 62 deletions(-)
google-beta provider View Diff 1 file changed, 107 insertions(+), 62 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1422 1328 91 3
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterBgpPeer_routerPeerRouterAppliance
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_routerApplianceInstance

View the build log


Step 2: Recording Mode

Test Name Recording Mode Replaying Rerun
TestAccComputeRouterBgpPeer_routerPeerRouterAppliance 🔴 Failed [Error message] [Debug log] -
TestAccComputeRouterPeer_AddMd5AuthenticationKey 🟢 Passed [Debug log] 🟢 Passed
TestAccComputeRouterPeer_routerApplianceInstance 🔴 Failed [Error message] [Debug log] -

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 49fdccf!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 290adb8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 150 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 150 insertions(+), 80 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1422 1323 91 8
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterBgpPeer_routerPeerRouterAppliance
  • TestAccComputeRouterInterface_basic
  • TestAccComputeRouterInterface_redundant
  • TestAccComputeRouterInterface_withIPVersionV4
  • TestAccComputeRouterInterface_withIPVersionV6
  • TestAccComputeRouterInterface_withPrivateIpAddress
  • TestAccComputeRouterInterface_withTunnel
  • TestAccComputeRouterPeer_routerApplianceInstance

View the build log


Step 2: Recording Mode

Test Name Recording Mode Replaying Rerun
TestAccComputeRouterBgpPeer_routerPeerRouterAppliance 🔴 Failed [Error message] [Debug log] -
TestAccComputeRouterInterface_basic 🔴 Failed [Error message] [Debug log] -
TestAccComputeRouterInterface_redundant 🔴 Failed [Error message] [Debug log] -
TestAccComputeRouterInterface_withIPVersionV4 🔴 Failed [Error message] [Debug log] -
TestAccComputeRouterInterface_withIPVersionV6 🔴 Failed [Error message] [Debug log] -
TestAccComputeRouterInterface_withPrivateIpAddress 🔴 Failed [Error message] [Debug log] -
TestAccComputeRouterInterface_withTunnel 🔴 Failed [Error message] [Debug log] -
TestAccComputeRouterPeer_routerApplianceInstance 🔴 Failed [Error message] [Debug log] -

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 290adb8!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 14d9a1c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1422 1331 91 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@nsamartsev VCR tests complete for 14d9a1c!

@nsamartsev nsamartsev force-pushed the resource-compute-router-interface-migration branch from 14d9a1c to f0e115a Compare May 4, 2026 14:34
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f0e115a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1422 1331 91 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@nsamartsev VCR tests complete for f0e115a!

@nsamartsev nsamartsev changed the title Migrate resource_compute_router_interface.go.tmpl resource to use direct HTTP rather than a client library Migrate resource_compute_router_interface.go.tmpl, resource_compute_router_interface_test.go.tmpl resource to use direct HTTP rather than a client library May 4, 2026
@nsamartsev nsamartsev marked this pull request as ready for review May 6, 2026 10:45
@github-actions github-actions Bot requested a review from c2thorn May 6, 2026 10:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@nsamartsev nsamartsev force-pushed the resource-compute-router-interface-migration branch from f0e115a to 5d8387a Compare May 11, 2026 09:35
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 11, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5d8387a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1445 1350 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSecurityPolicyRule_securityPolicyRuleWithBodyExcludeExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@nsamartsev, @c2thorn VCR tests complete for 5d8387a!

@github-actions
Copy link
Copy Markdown

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@nsamartsev nsamartsev force-pushed the resource-compute-router-interface-migration branch from 5d8387a to 05b10cc Compare May 13, 2026 14:12
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 13, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 05b10cc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1446 1351 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@nsamartsev, @c2thorn VCR tests complete for 05b10cc!

@nsamartsev nsamartsev force-pushed the resource-compute-router-interface-migration branch from 05b10cc to fd950c1 Compare May 18, 2026 12:40
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 18, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fd950c1:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 153 insertions(+), 80 deletions(-)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • compute

Please fix the compilation errors to complete your PR.

View the build log

@nsamartsev, @c2thorn VCR tests complete for fd950c1!

@nsamartsev nsamartsev force-pushed the resource-compute-router-interface-migration branch from fd950c1 to 138f7a4 Compare May 18, 2026 12:58
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 18, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 138f7a4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 154 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 154 insertions(+), 80 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1445 1350 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev, @c2thorn VCR tests complete for 138f7a4!

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@nsamartsev nsamartsev force-pushed the resource-compute-router-interface-migration branch from 138f7a4 to 3318130 Compare May 20, 2026 14:01
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 20, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3318130:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 154 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 154 insertions(+), 80 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1447 1354 93 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@nsamartsev, @c2thorn VCR tests complete for 3318130!

@nsamartsev
Copy link
Copy Markdown
Contributor Author

Hello @c2thorn

Could you please review this PR when you have a moment?
Many thanks.

@nsamartsev nsamartsev force-pushed the resource-compute-router-interface-migration branch from 3318130 to ab4f92e Compare May 25, 2026 16:58
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 25, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ab4f92e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 154 insertions(+), 80 deletions(-)
google-beta provider View Diff 2 files changed, 154 insertions(+), 80 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1364 93 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@nsamartsev, @c2thorn VCR tests complete for ab4f92e!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants