Skip to content

Add field targetProxies to resources google_network_services_tls_route (beta)#16768

Draft
rostislavbobo wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
rostislavbobo:tlsroute-target-tcp-proxy-regional
Draft

Add field targetProxies to resources google_network_services_tls_route (beta)#16768
rostislavbobo wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
rostislavbobo:tlsroute-target-tcp-proxy-regional

Conversation

@rostislavbobo
Copy link
Member

Add the targetProxies field to TLSRoute resource for regional Target TCP Proxy.

Fixes hashicorp/terraform-provider-google#26503

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `targetProxies` to resource `google_network_services_tls_route` (beta)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 307 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 5 files changed, 307 insertions(+), 24 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field location added as optional with a default value and force new on pre-existing resource google_network_services_tls_route. This can be allowed if there is a confirmed API-level default that matches the schema default - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 97
Passed tests: 90
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesTlsRoute_networkServicesTlsRouteRegionalBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesTlsRoute_networkServicesTlsRouteRegionalBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform support for TLSRoute for regional Target TCP Proxies (beta)

2 participants