Skip to content

Add creation of IAM resources for Agent Engine / ReasoningEngine reso…#16764

Draft
mmontan wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mmontan:vertex-ai-reasoning-engine-iam
Draft

Add creation of IAM resources for Agent Engine / ReasoningEngine reso…#16764
mmontan wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mmontan:vertex-ai-reasoning-engine-iam

Conversation

@mmontan
Copy link
Contributor

@mmontan mmontan commented Mar 19, 2026

vertexai: added IAM policy support for google_vertex_ai_reasoning_engine (beta)

vertexai: added IAM support for `google_vertex_ai_reasoning_engine` resource (beta)                                                                           

TODO: add an issue.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 223 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 808 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 384 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_reasoning_engine_iam_binding
  • google_vertex_ai_reasoning_engine_iam_member
  • google_vertex_ai_reasoning_engine_iam_policy

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 88
Passed tests: 82
Skipped tests: 3
Affected tests: 3

Click here to see the affected service packages
  • vertexai

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAIReasoningEngineIamBindingGenerated
  • TestAccVertexAIReasoningEngineIamMemberGenerated
  • TestAccVertexAIReasoningEngineIamPolicyGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVertexAIReasoningEngineIamBindingGenerated [Debug log]
TestAccVertexAIReasoningEngineIamMemberGenerated [Debug log]
TestAccVertexAIReasoningEngineIamPolicyGenerated [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants