Fix: Include user_service_account_mapping in Dataproc update mask#16760
Open
anjalimalik wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Fix: Include user_service_account_mapping in Dataproc update mask#16760anjalimalik wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
anjalimalik wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
…mapping to properly handle updates to cluster security identity config.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Collaborator
Collaborator
Tests analyticsTotal tests: 83 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the
resourceDataprocClusterUpdatefunction to explicitly includeuser_service_account_mappingin the update mask. This ensures that changes to the identity config are correctly detected and propagated to the Dataproc API during a Terraform apply.