feat: support `server_certificate_rotation_mode` for SQL instance by shuyama1 · Pull Request #16743 · GoogleCloudPlatform/magic-modules

shuyama1 · 2026-03-17T17:10:11Z

Reverts #16398 to reintroduce #16320

sql: added `server_certificate_rotation_mode` field to `google_sql_database_instance` resource

…ode for …" This reverts commit c822797.

shuyama1 · 2026-03-17T17:11:34Z

@wuchris-g FYI

wuchris-g · 2026-03-17T17:15:28Z

mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl

+	if newMode == "" && oldMode == "SERVER_CERTIFICATE_ROTATION_MODE_UNSPECIFIED" {
+        	return true
+	}
+    	return false


Tabs vs. spaces looks inconsistent in this function. Looks like I messed that up in #16320

mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl

modular-magician · 2026-03-17T17:32:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 79 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 79 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (243 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    ip_configuration {
      enable_private_path_for_google_cloud_services = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_sql_database_instance
- Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
- Fields: [settings.ip_configuration.server_certificate_rotation_mode]

modular-magician · 2026-03-17T17:32:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 79 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 79 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (243 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    ip_configuration {
      enable_private_path_for_google_cloud_services = # value needed
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_sql_database_instance
- Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
- Fields: [settings.ip_configuration.server_certificate_rotation_mode]

modular-magician · 2026-03-17T17:45:53Z

Tests analytics

Total tests: 149
Passed tests: 71
Skipped tests: 27
Affected tests: 51

Click here to see the affected service packages

sql

Action taken

Found 51 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig

TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

TestAccSqlDatabaseInstance_AutoUpgradeEnabled

TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithDiskSize

TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithoutDiskSize

TestAccSqlDatabaseInstance_Edition_Downgrade

TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration

TestAccSqlDatabaseInstance_EnableGoogleMlIntegration

TestAccSqlDatabaseInstance_FinalBackupConfig

TestAccSqlDatabaseInstance_MysqlEplusWithFailoverReplicaSetupWithPrivateNetwork

TestAccSqlDatabaseInstance_MysqlReadPoolAutoScaleEnableDisableSuccess

TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess

TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess

TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer

TestAccSqlDatabaseInstance_PostgresEplusWithFailoverReplicaSetupWithPrivateNetwork

TestAccSqlDatabaseInstance_PostgresReadPoolAutoScaleChangeNodeCount

TestAccSqlDatabaseInstance_PostgresReadPoolScaleOutSuccess

TestAccSqlDatabaseInstance_PostgresReadPoolScaleUpSuccess

TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess

TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade

TestAccSqlDatabaseInstance_RetainBackupOnDelete

TestAccSqlDatabaseInstance_Smt

TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate

TestAccSqlDatabaseInstance_SwitchoverSuccess

TestAccSqlDatabaseInstance_authNets

TestAccSqlDatabaseInstance_basicMSSQL

TestAccSqlDatabaseInstance_basicMSSQL_passwordWo

TestAccSqlDatabaseInstance_basic_with_user_labels

TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance

TestAccSqlDatabaseInstance_hyperdisk

TestAccSqlDatabaseInstance_insights_enhanced_postgres17

TestAccSqlDatabaseInstance_majorVersionUpgradeForEnhancedBackupTierInstance

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable

TestAccSqlDatabaseInstance_settings_deletionProtection

TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled

TestAccSqlDatabaseInstance_settings_upgrade

TestAccSqlDatabaseInstance_updateInstanceTierForEnhancedBackupTierInstance

TestAccSqlDatabaseInstance_updateMCPEnabled

TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

TestAccSqlDatabaseInstance_useCustomSubjectAlternateName

TestAccSqlDatabaseInstance_useCustomerManagedServerCa

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment

TestAccSqlDatabase_instanceWithActivationPolicy

Get to know how VCR tests work

modular-magician · 2026-03-17T17:49:17Z

Tests analytics

Total tests: 149
Passed tests: 71
Skipped tests: 27
Affected tests: 51

Click here to see the affected service packages

sql

Action taken

Found 51 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig

TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

TestAccSqlDatabaseInstance_AutoUpgradeEnabled

TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithDiskSize

TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithoutDiskSize

TestAccSqlDatabaseInstance_Edition_Downgrade

TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration

TestAccSqlDatabaseInstance_EnableGoogleMlIntegration

TestAccSqlDatabaseInstance_FinalBackupConfig

TestAccSqlDatabaseInstance_MysqlEplusWithFailoverReplicaSetupWithPrivateNetwork

TestAccSqlDatabaseInstance_MysqlReadPoolAutoScaleEnableDisableSuccess

TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess

TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess

TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer

TestAccSqlDatabaseInstance_PostgresEplusWithFailoverReplicaSetupWithPrivateNetwork

TestAccSqlDatabaseInstance_PostgresReadPoolAutoScaleChangeNodeCount

TestAccSqlDatabaseInstance_PostgresReadPoolScaleOutSuccess

TestAccSqlDatabaseInstance_PostgresReadPoolScaleUpSuccess

TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess

TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade

TestAccSqlDatabaseInstance_RetainBackupOnDelete

TestAccSqlDatabaseInstance_Smt

TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate

TestAccSqlDatabaseInstance_SwitchoverSuccess

TestAccSqlDatabaseInstance_authNets

TestAccSqlDatabaseInstance_basicMSSQL

TestAccSqlDatabaseInstance_basicMSSQL_passwordWo

TestAccSqlDatabaseInstance_basic_with_user_labels

TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance

TestAccSqlDatabaseInstance_hyperdisk

TestAccSqlDatabaseInstance_insights_enhanced_postgres17

TestAccSqlDatabaseInstance_majorVersionUpgradeForEnhancedBackupTierInstance

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable

TestAccSqlDatabaseInstance_settings_deletionProtection

TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled

TestAccSqlDatabaseInstance_settings_upgrade

TestAccSqlDatabaseInstance_updateInstanceTierForEnhancedBackupTierInstance

TestAccSqlDatabaseInstance_updateMCPEnabled

TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

TestAccSqlDatabaseInstance_useCustomSubjectAlternateName

TestAccSqlDatabaseInstance_useCustomerManagedServerCa

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment

TestAccSqlDatabase_instanceWithActivationPolicy

Get to know how VCR tests work

modular-magician · 2026-03-17T18:54:38Z

🟢 Tests passed during RECORDING mode:
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSqlDatabaseInstance_AutoUpgradeEnabled [Debug log]
TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithDiskSize [Debug log]
TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithoutDiskSize [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_FinalBackupConfig [Debug log]
TestAccSqlDatabaseInstance_MysqlEplusWithFailoverReplicaSetupWithPrivateNetwork [Debug log]
TestAccSqlDatabaseInstance_MysqlReadPoolAutoScaleEnableDisableSuccess [Debug log]
TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresEplusWithFailoverReplicaSetupWithPrivateNetwork [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolAutoScaleChangeNodeCount [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolScaleOutSuccess [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolScaleUpSuccess [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_RetainBackupOnDelete [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL_passwordWo [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_hyperdisk [Debug log]
TestAccSqlDatabaseInstance_insights_enhanced_postgres17 [Debug log]
TestAccSqlDatabaseInstance_majorVersionUpgradeForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_updateInstanceTierForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_updateMCPEnabled [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_useCustomSubjectAlternateName [Debug log]
TestAccSqlDatabaseInstance_useCustomerManagedServerCa [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2026-03-17T18:57:29Z

🟢 Tests passed during RECORDING mode:
TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig [Debug log]
TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig [Debug log]
TestAccSqlDatabaseInstance_AutoUpgradeEnabled [Debug log]
TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithDiskSize [Debug log]
TestAccSqlDatabaseInstance_DiskSizeAutoResizeWithoutDiskSize [Debug log]
TestAccSqlDatabaseInstance_Edition_Downgrade [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration [Debug log]
TestAccSqlDatabaseInstance_EnableGoogleMlIntegration [Debug log]
TestAccSqlDatabaseInstance_FinalBackupConfig [Debug log]
TestAccSqlDatabaseInstance_MysqlEplusWithFailoverReplicaSetupWithPrivateNetwork [Debug log]
TestAccSqlDatabaseInstance_MysqlReadPoolAutoScaleEnableDisableSuccess [Debug log]
TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess [Debug log]
TestAccSqlDatabaseInstance_MysqlSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled [Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer [Debug log]
TestAccSqlDatabaseInstance_PostgresEplusWithFailoverReplicaSetupWithPrivateNetwork [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolAutoScaleChangeNodeCount [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolScaleOutSuccess [Debug log]
TestAccSqlDatabaseInstance_PostgresReadPoolScaleUpSuccess [Debug log]
TestAccSqlDatabaseInstance_PostgresSwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade [Debug log]
TestAccSqlDatabaseInstance_RetainBackupOnDelete [Debug log]
TestAccSqlDatabaseInstance_Smt [Debug log]
TestAccSqlDatabaseInstance_SqlServerTimezoneUpdate [Debug log]
TestAccSqlDatabaseInstance_SwitchoverSuccess [Debug log]
TestAccSqlDatabaseInstance_authNets [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL [Debug log]
TestAccSqlDatabaseInstance_basicMSSQL_passwordWo [Debug log]
TestAccSqlDatabaseInstance_basic_with_user_labels [Debug log]
TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls [Debug log]
TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_hyperdisk [Debug log]
TestAccSqlDatabaseInstance_insights_enhanced_postgres17 [Debug log]
TestAccSqlDatabaseInstance_majorVersionUpgradeForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtection [Debug log]
TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled [Debug log]
TestAccSqlDatabaseInstance_settings_upgrade [Debug log]
TestAccSqlDatabaseInstance_updateInstanceTierForEnhancedBackupTierInstance [Debug log]
TestAccSqlDatabaseInstance_updateMCPEnabled [Debug log]
TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled [Debug log]
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL [Debug log]
TestAccSqlDatabaseInstance_useCustomSubjectAlternateName [Debug log]
TestAccSqlDatabaseInstance_useCustomerManagedServerCa [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject [Debug log]
TestAccSqlDatabaseInstance_withPSCEnabled_thenAddPscAutoConnections_thenRemovePscAutoConnections [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange [Debug log]
TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemoveNetworkAttachment [Debug log]
TestAccSqlDatabase_instanceWithActivationPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Revert "Revert "feat: support new field server_certificate_rotation_m…

272cd23

…ode for …" This reverts commit c822797.

wuchris-g reviewed Mar 17, 2026

View reviewed changes

shuyama1 commented Mar 17, 2026

View reviewed changes

mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl Outdated Show resolved Hide resolved

Apply suggestion from @shuyama1

b4ddec8

modular-magician added the service/sqladmin-cp label Mar 17, 2026

shuyama1 requested a review from NickElliot March 19, 2026 18:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support `server_certificate_rotation_mode` for SQL instance#16743

feat: support `server_certificate_rotation_mode` for SQL instance#16743
shuyama1 wants to merge 2 commits intomainfrom
revert-16398-revert-16320-auto-rotation2

shuyama1 commented Mar 17, 2026

Uh oh!

shuyama1 commented Mar 17, 2026

Uh oh!

wuchris-g Mar 17, 2026

Uh oh!

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shuyama1 commented Mar 17, 2026

Uh oh!

shuyama1 commented Mar 17, 2026

Uh oh!

wuchris-g Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Mar 17, 2026

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Mar 17, 2026

Diff report

Missing test report

Missing doc report (experimental)

Uh oh!

modular-magician commented Mar 17, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 17, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

modular-magician commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants