Skip to content

Migrated security policy setting to use transport_tpg.SendRequest#16738

Open
nsamartsev wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
nsamartsev:compute-backend-service-sendrequest-migration
Open

Migrated security policy setting to use transport_tpg.SendRequest#16738
nsamartsev wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
nsamartsev:compute-backend-service-sendrequest-migration

Conversation

@nsamartsev
Copy link

@nsamartsev nsamartsev commented Mar 17, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated security policy setting to use transport_tpg.SendRequest 

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 17, 2026
@github-actions github-actions bot requested a review from zli82016 March 17, 2026 12:16
@github-actions
Copy link

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 17, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 92 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 1 file changed, 92 insertions(+), 24 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1384
Passed tests: 1293
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_withSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_withSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@nsamartsev nsamartsev force-pushed the compute-backend-service-sendrequest-migration branch from 65f4e54 to fbb350c Compare March 17, 2026 16:49
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 17, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 92 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 1 file changed, 92 insertions(+), 24 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1384
Passed tests: 1293
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_withSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_withSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 18, 2026
@nsamartsev nsamartsev force-pushed the compute-backend-service-sendrequest-migration branch from 3b7b9cd to a3dde02 Compare March 18, 2026 01:50
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 18, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 92 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 1 file changed, 92 insertions(+), 24 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1386
Passed tests: 1295
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeBackendService_withSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_withSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants