Skip to content

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Jan 24, 2026

Use the test bucket cai_assets_metadata_test for now, as the test bucket has the fixed data. Will make the same change and change back to cai_assets_metadata if no issues are observed.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@zli82016 zli82016 force-pushed the tgc-ignore-ExtraSchemaEntry branch from bb81101 to 6a888ac Compare January 24, 2026 05:20
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 11 files changed, 168 insertions(+), 125 deletions(-))

@zli82016 zli82016 force-pushed the tgc-ignore-ExtraSchemaEntry branch from 6a888ac to 4b38e68 Compare January 24, 2026 05:43
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 10 files changed, 166 insertions(+), 124 deletions(-))

@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 10 files changed, 166 insertions(+), 124 deletions(-))

@zli82016 zli82016 force-pushed the tgc-ignore-ExtraSchemaEntry branch from 4b38e68 to a0fc067 Compare January 24, 2026 23:23
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 11 files changed, 167 insertions(+), 125 deletions(-))

@zli82016 zli82016 force-pushed the tgc-ignore-ExtraSchemaEntry branch from a0fc067 to ed26d87 Compare January 24, 2026 23:50
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 11 files changed, 168 insertions(+), 126 deletions(-))

@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 11 files changed, 168 insertions(+), 126 deletions(-))

@zli82016 zli82016 force-pushed the tgc-ignore-ExtraSchemaEntry branch from ed26d87 to 28d71fe Compare January 26, 2026 17:29
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 11 files changed, 167 insertions(+), 125 deletions(-))

@zli82016 zli82016 changed the title test tgc-revival: generate handwritten tests by default Jan 26, 2026
@zli82016 zli82016 marked this pull request as ready for review January 26, 2026 22:14
@zli82016 zli82016 requested a review from trodge January 26, 2026 22:14
@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 11 files changed, 167 insertions(+), 125 deletions(-))

@zli82016 zli82016 added this pull request to the merge queue Jan 27, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 2d2ade6 Jan 27, 2026
29 checks passed
@zli82016 zli82016 deleted the tgc-ignore-ExtraSchemaEntry branch January 27, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants