-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update provider versions page link to relative links on provider_versions.html.markdown
#16205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update provider versions page link to relative links on provider_versions.html.markdown
#16205
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Never mind, I checked a relative link accidentally- AWS has |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1330 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 1330 Click here to see the affected service packages
🟢 All tests passed! View the build log |
provider_versions.html.markdown
BBBmau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, updated the title of the PR to match the edit
0a2b8cb
I confirmed by checking the "Enforcing Tag Policy Compliance" link on https://registry.terraform.io/providers/hashicorp/aws/6.24.0/docs/guides/tag-policy-compliance thatlatestis rewritten to the version picked through the version selector.Never mind, I checked a relative link accidentally- AWS has
aws_organizations_policyon https://registry.terraform.io/providers/hashicorp/aws/6.24.0/docs/guides/tag-policy-compliance that sends you tolatestThe relative file link Dynamic Tagging example on https://registry.terraform.io/providers/hashicorp/aws/6.24.0/docs/guides/version-5-upgrade does show correct behaviour, though, so do that.
note
../guides/provider_versions.html.markdownprefix from resource and DS directories, and./provider_versions.html.markdownfor otherguides/entriesRelease Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.