Skip to content

Conversation

@pcostell
Copy link
Contributor

@pcostell pcostell commented Jan 23, 2026

Add skip_wait field to google_firestore_index resource

This field allows users to skip waiting for the long-running operation to complete during index creation. This is useful for creating multiple indexes in parallel or when usage patterns do not require immediate index readiness.

Also adds support for updating virtual fields on otherwise immutable resources.

Fixes hashicorp/terraform-provider-google#13422

Release Note Template for Downstream PRs (will be copied)

firestore: added `skip_wait` field to `google_firestore_index` resource, skipping the wait for index creation

Virtual fields are client-only, so should be updatable even if the resoruce is immutable. Leverage the same flow as labels.

Change-Id: Idf0728266ce2d345608e8dd098ce6da61ea6d234
@github-actions github-actions bot requested a review from shuyama1 January 23, 2026 17:23
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

When skip_wait is set to true, terraform will not wait for the index creation to complete before returning.

Fixes hashicorp/terraform-provider-google#13422

Change-Id: I5c5243e92fef8c3417bf6d569a4824d726492c89
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 34 files changed, 171 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 38 files changed, 175 insertions(+), 47 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 34 files changed, 171 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 38 files changed, 175 insertions(+), 47 deletions(-))

constants: 'templates/terraform/constants/firestore_index.go.tmpl'
encoder: 'templates/terraform/encoders/index.go.tmpl'
custom_import: 'templates/terraform/custom_import/index_self_link_as_name_set_project.go.tmpl'
custom_create: 'templates/terraform/custom_create/firestore_index.go.tmpl'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by comment: @shuyama1 can you evaluate making a template change to make this possible w/o a full custom create? This needs minimal structural change, so a custom method is pretty heavyhanded but there's no appropriate injection point atm.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 709
Passed tests: 656
Skipped tests: 52
Affected tests: 1

Click here to see the affected service packages
  • beyondcorp
  • bigquery
  • certificatemanager
  • clouddomains
  • developerconnect
  • edgenetwork
  • firestore
  • networkservices
  • colab
  • dataproc
  • datastream
  • firebaseapphosting
  • mlengine
  • networkconnectivity
  • networksecurity
  • securesourcemanager
  • apihub
  • dataprocgdc
  • oracledatabase
  • saasruntime
  • databasemigrationservice
  • transcoder

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreIndex_firestoreIndexSkipWaitExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFirestoreIndex_firestoreIndexSkipWaitExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 709
Passed tests: 656
Skipped tests: 52
Affected tests: 1

Click here to see the affected service packages
  • transcoder
  • clouddomains
  • firestore
  • apihub
  • beyondcorp
  • bigquery
  • databasemigrationservice
  • developerconnect
  • edgenetwork
  • mlengine
  • networksecurity
  • certificatemanager
  • colab
  • datastream
  • firebaseapphosting
  • networkconnectivity
  • networkservices
  • oracledatabase
  • securesourcemanager
  • dataproc
  • dataprocgdc
  • saasruntime

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreIndex_firestoreIndexSkipWaitExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFirestoreIndex_firestoreIndexSkipWaitExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_firestore_index non-blocking option

3 participants