-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(firestore): Support for skip wait on Firestore index resource. #16203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Virtual fields are client-only, so should be updatable even if the resoruce is immutable. Leverage the same flow as labels. Change-Id: Idf0728266ce2d345608e8dd098ce6da61ea6d234
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
When skip_wait is set to true, terraform will not wait for the index creation to complete before returning. Fixes hashicorp/terraform-provider-google#13422 Change-Id: I5c5243e92fef8c3417bf6d569a4824d726492c89
cc44c24 to
55938b6
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
| constants: 'templates/terraform/constants/firestore_index.go.tmpl' | ||
| encoder: 'templates/terraform/encoders/index.go.tmpl' | ||
| custom_import: 'templates/terraform/custom_import/index_self_link_as_name_set_project.go.tmpl' | ||
| custom_create: 'templates/terraform/custom_create/firestore_index.go.tmpl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by comment: @shuyama1 can you evaluate making a template change to make this possible w/o a full custom create? This needs minimal structural change, so a custom method is pretty heavyhanded but there's no appropriate injection point atm.
Tests analyticsTotal tests: 709 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 709 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Add
skip_waitfield togoogle_firestore_indexresourceThis field allows users to skip waiting for the long-running operation to complete during index creation. This is useful for creating multiple indexes in parallel or when usage patterns do not require immediate index readiness.
Also adds support for updating virtual fields on otherwise immutable resources.
Fixes hashicorp/terraform-provider-google#13422
Release Note Template for Downstream PRs (will be copied)