Update networkservices multicast domain

[TimDu]

Part of hashicorp/terraform-provider-google#24791

networkservices: added `ull_multicast_domain` field to `google_network_services_multicast_domain` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 166 insertions(+))
google-beta provider: Diff ( 4 files changed, 166 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_multicast_domain (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_multicast_domain" "primary" {
  ull_multicast_domain {
    preconfigured_ull_domain = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 166 insertions(+))
google-beta provider: Diff ( 4 files changed, 166 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_multicast_domain (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_multicast_domain" "primary" {
  ull_multicast_domain {
    preconfigured_ull_domain = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 166 insertions(+))
google-beta provider: Diff ( 4 files changed, 166 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 170 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 170 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[trodge]

Test is failing with

  error=
  | exit status 1
  | 
  | Error: Error waiting to create MulticastDomain: Error waiting for Creating MulticastDomain: Error code 3, message: The request was invalid: ULL multicast validation failed: failed to check the project allowlist: project 1067888929963 is not allowlisted for ULL multicast
  | 
  |   with google_network_services_multicast_domain.md_test,
  |   on terraform_plugin_test.tf line 7, in resource "google_network_services_multicast_domain" "md_test":
  |    7: resource "google_network_services_multicast_domain" md_test {
  | 

[TimDu]

Thanks @trodge , I am submitting a internal fix to allowlist projects, the rollout complete in ~2 days. Sending this PR to queue for a test in paralell.

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test