Skip to content

Conversation

@muresan
Copy link

@muresan muresan commented Jan 21, 2026

Fixes: hashicorp/terraform-provider-google#24626

compute: Enable write-only support for `private_key` to `google_compute_ssl_certificate` resource
compute: Enable write-only support for `private_key` to `google_compute_region_ssl_certificate` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 21, 2026
@github-actions github-actions bot requested a review from trodge January 21, 2026 14:39
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@muresan muresan changed the title Enable write-only support for private_key from google_compute_ssl_certificate Enable write-only support for private_key from google_compute_(region_)ssl_certificate Jan 23, 2026
@modular-magician modular-magician added service/certificatemanager and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 23, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 134 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 8 files changed, 134 insertions(+), 32 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 62 insertions(+), 15 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_ssl_certificate (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

Resource: google_compute_ssl_certificate (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_ssl_certificate" "primary" {
  private_key_wo         = # value needed
  private_key_wo_version = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1330
Passed tests: 1244
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't set an ephemeral value as the private_key argument of compute_ssl_certificate

2 participants