-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(logging): Add Cloud Logging Saved Query resource #16182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(logging): Add Cloud Logging Saved Query resource #16182
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
Ran tests locally:
sh -c "'/Users/ramon/go/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/logging -v -run=TestAccLoggingSavedQuery_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN TestAccLoggingSavedQuery_loggingSavedQueryBasicExample
=== PAUSE TestAccLoggingSavedQuery_loggingSavedQueryBasicExample
=== RUN TestAccLoggingSavedQuery_loggingSavedQueryPrivateExample
=== PAUSE TestAccLoggingSavedQuery_loggingSavedQueryPrivateExample
=== RUN TestAccLoggingSavedQuery_loggingSavedQuerySummaryFieldsExample
=== PAUSE TestAccLoggingSavedQuery_loggingSavedQuerySummaryFieldsExample
=== RUN TestAccLoggingSavedQuery_loggingSavedQuerySqlBasicExample
=== PAUSE TestAccLoggingSavedQuery_loggingSavedQuerySqlBasicExample
=== RUN TestAccLoggingSavedQuery_update
=== PAUSE TestAccLoggingSavedQuery_update
=== CONT TestAccLoggingSavedQuery_loggingSavedQueryBasicExample
=== CONT TestAccLoggingSavedQuery_loggingSavedQuerySqlBasicExample
=== CONT TestAccLoggingSavedQuery_loggingSavedQuerySummaryFieldsExample
=== CONT TestAccLoggingSavedQuery_update
=== CONT TestAccLoggingSavedQuery_loggingSavedQueryPrivateExample
--- PASS: TestAccLoggingSavedQuery_loggingSavedQuerySummaryFieldsExample (7.36s)
--- PASS: TestAccLoggingSavedQuery_loggingSavedQueryBasicExample (7.87s)
--- PASS: TestAccLoggingSavedQuery_loggingSavedQueryPrivateExample (8.01s)
--- PASS: TestAccLoggingSavedQuery_loggingSavedQuerySqlBasicExample (8.17s)
--- PASS: TestAccLoggingSavedQuery_update (12.32s)
PASS
ok github.com/hashicorp/terraform-provider-google/google/services/logging 13.990s
mmv1/third_party/terraform/services/logging/resource_logging_saved_query_test.go
Outdated
Show resolved
Hide resolved
…aved_query_test.go Co-authored-by: Ramon Vermeulen <ramonvermeulen98@gmail.com>
This PR adds a resource for Cloud Logging Saved Queries, which can be used for both Logging Saved Queries and Log Analytics Saved Queries.
Fixes hashicorp/terraform-provider-google#18023
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.