Skip to content

Add duration cmd line parameters#435

Open
edhaight wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
edhaight:master
Open

Add duration cmd line parameters#435
edhaight wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
edhaight:master

Conversation

@edhaight
Copy link

@edhaight edhaight commented Sep 4, 2021

  • Added alignment period cmd line parameter.
  • Added rate interval cmd line parameter.
  • Refactored alignment period and rate interval
    to be fields of the server options struct.

- Added alignment period cmd line parameter.
- Added rate interval cmd line parameter.
- Refactored alignment period and rate interval
  to be fields of the server options struct.
@google-cla
Copy link

google-cla bot commented Sep 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 4, 2021
@edhaight
Copy link
Author

edhaight commented Sep 4, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 4, 2021
@juli4n juli4n added the custom-metrics-stackdriver-adapter Issues for custom-metrics-stackdriver-adapter label Aug 4, 2025
@juli4n
Copy link
Contributor

juli4n commented Aug 4, 2025

Thanks for the pull request. Are you still interested in making this contribution?

Could you elaborate a bit more on the motivations behind this change? e.g. how users will decide when to pick different values? Updating the documentation in this CL with instructions on how (and when) to use these new knobs would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes custom-metrics-stackdriver-adapter Issues for custom-metrics-stackdriver-adapter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants