[prometheus-to-sd] Add quantiles to summary type#234
[prometheus-to-sd] Add quantiles to summary type#234AttwellBrian wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
2994337 to
0a0bc44
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| }, | ||
| MetricKind: "GAUGE", | ||
| Points: []*v3.Point{ | ||
| // Like all gauges the translater assumes it is an integer, unfortunately :( |
There was a problem hiding this comment.
This is a seperate issue that I'll look into in a separate diff.
I've seen this cause some frustrating issues before, outside of summary metric types.
|
|
As discussed in #196, summary quantiles cannot be aggregated well. However, they are still useful and frequently used by Prometheus exporters. In order to allow stackdriver to be more of a drop in replacement for prom, this diff adds support for summary quantiles
Each quantile acts like a seperate label value. For the gauge.
Test Plan
Modified
translater_test.go. Temporarily added the following to theDockerfile. Then ran theDockerfile.