Skip to content

Fix early return in multi-batch metric scraping #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
courageJ wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix early return in multi-batch metric scraping #1202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions kubelet-to-gcm/monitor/poll.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,7 @@ func Once(src MetricsSource, gcm *v3.Service) {
if empty, err := createCall.Do(); err != nil {
log.Warningf("Failed to write time series data, empty: %v, err: %v", empty, err)
observeFailedRequest(len(subReq.TimeSeries))
jsonReq, err := subReq.MarshalJSON()
if err != nil {
log.Warningf("Failed to marshal time series as JSON")
return
}
log.Warningf("JSON GCM: %s", string(jsonReq[:]))
return
continue
}
log.V(4).Infof("Successfully wrote TimeSeries data for %s to GCM v3 API.", src.Name())
observeSuccessfullRequest(len(subReq.TimeSeries))
Expand Down
Loading