Skip to content

Conversation

@lakshmansai
Copy link

@lakshmansai lakshmansai commented Dec 5, 2025

Summary: Upgrade fluentd to 1.19, Ruby to 3.2, grpc to 1.70.1

Fix linting issues pointed by robocop.

Fixes #519

Test plan

bundle install

bundle exec rake


➜  fluent-plugin-google-cloud git:(upgrade_fluentd) ✗ bundle exec rake

Running RuboCop...
Inspecting 20 files
....................

20 files inspected, no offenses detected

Tip: Based on detected gems, the following RuboCop extension libraries might be helpful:
  * rubocop-rake (https://rubygems.org/gems/rubocop-rake)

You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options):
  AllCops:
    SuggestExtensions: false
/home/ubuntu/.rvm/rubies/ruby-3.2.2/bin/ruby -w -I"lib:lib:test" /home/ubuntu/.rvm/rubies/ruby-3.2.2/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb "test/plugin/asserts.rb" "test/plugin/base_test.rb" "test/plugin/constants.rb" "test/plugin/test_driver.rb" "test/plugin/test_filter_add_insert_ids.rb" "test/plugin/test_filter_analyze_config.rb" "test/plugin/test_out_google_cloud.rb" "test/plugin/test_out_google_cloud_grpc.rb" "test/plugin/utils.rb"
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's default settings.
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/io-event-1.10.2/lib/io/event/support.rb:48: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/fluentd-1.19.0/lib/fluent/plugin_helper.rb:46: warning: method redefined; discarding old inherited
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/fluentd-1.19.0/lib/fluent/plugin_helper.rb:46: warning: previous definition of inherited was here
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/google-apis-core-0.11.3/lib/google/apis/core/base_service.rb:228: warning: method redefined; discarding old client
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/google-cloud-logging-v2-0.11.0/lib/google/logging/v2/logging_pb.rb:25: warning: assigned but unused variable - e
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/google-cloud-logging-v2-0.11.0/lib/google/logging/v2/log_entry_pb.rb:24: warning: assigned but unused variable - e
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/google-cloud-logging-v2-0.11.0/lib/google/logging/v2/logging_config_pb.rb:24: warning: assigned but unused variable - e
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/google-cloud-logging-v2-0.11.0/lib/google/logging/v2/logging_metrics_pb.rb:24: warning: assigned but unused variable - e
Loaded suite /home/ubuntu/.rvm/rubies/ruby-3.2.2/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader
Started
.../home/ubuntu/.rvm/gems/ruby-3.2.2/gems/google-cloud-trace-v2-0.7.0/lib/google/devtools/cloudtrace/v2/tracing_pb.rb:22: warning: assigned but unused variable - e
/home/ubuntu/.rvm/gems/ruby-3.2.2/gems/google-cloud-trace-v2-0.7.0/lib/google/devtools/cloudtrace/v2/trace_pb.rb:21: warning: assigned but unused variable - e
.............................................................................................................................................................................................................................................
Finished in 324.598372469 seconds.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
240 tests, 36418 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.74 tests/s, 112.19 assertions/s
[Coveralls] Outside the CI environment, not sending data.
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR

Build gem

rake build

@google-cla
Copy link

google-cla bot commented Dec 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lakshmansai lakshmansai changed the title Upgrade fluentd to 1.19, Ruby to 3.2 Upgrade fluentd to 1.19, Ruby to 3.2,grpc to 1.70.1 Dec 5, 2025
@lakshmansai
Copy link
Author

cc @jefferbrecht

@lakshmansai
Copy link
Author

cc @jefferbrecht
Can you PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not work with fluentd 1.19

1 participant