chore: audit test csql instances #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
requested changes
Feb 21, 2025
CONTRIBUTING.md
Outdated
| # Postgres instance with IAM authentication enabled | ||
| # (can be same as POSTGRES_CONNECTION_NAME) | ||
| export POSTGRES_IAM_CONNECTION_NAME="<PROJECT>:<REGION>:<INSTANCE>" | ||
| export POSTGRES_CONNECTION_NAME="<PROJECT>:<REGION>:<INSTANCE>" |
Collaborator
There was a problem hiding this comment.
we should just remove this line as we already have an export line for this variable above on line 70...
We should copy the comment # Postgres instance with IAM authentication enabled to above line 70.
Collaborator
There was a problem hiding this comment.
Also should do the same for MYSQL_IAM_CONNECTION_NAME
jackwotherspoon
changed the title
kgala2
changed the title
jackwotherspoon
requested changes
Feb 24, 2025
| export MYSQL_USER="db_user" | ||
| export MYSQL_PASS="db_pass" | ||
| export MYSQL_DB="db_name" | ||
| # MySQL instance with IAM authentication enabled |
Collaborator
There was a problem hiding this comment.
can we move the # MySQL instance with IAM authentication enabled comment above
export MYSQL_CONNECTION_NAME="<PROJECT>:<REGION>:<INSTANCE>"Same with Postgres below...
jackwotherspoon
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate Cloud SQL instance usage for end-to-end connectivity testing in the following cases: