feat: add support for passing access tokens, or access token credential files to the keyring as environment variables #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…al files to the keyring as environment variables Sometimes, there are scenarios where keyring needs to be invoked from a docker container, and you would probably not want to install 'gcloud' in your docker container to keep it light weight. in these cases, its easier for the developer to create the access config file using gcloud outside the docker build, and then passing them as a docker secret. a specific scenario: while using google cloud build along with docker buildkit, the google auth keyring does not work, because the docker builder needs to be building on --network=cloudbuild, but --network=cloudbuild is an unsupported network on docker buildkit builder
srevinsaju
force-pushed
the
work/srevin/flexible-access-tokens
branch
from
160c783 to
0f7b86b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, there are scenarios where keyring needs to be invoked from a docker container, and you would probably not want to install 'gcloud' in your docker container to keep it light weight. in these cases, its easier for the developer to create the access config file using gcloud outside the docker build, and then passing them as a docker secret.
a specific scenario: while using google cloud build along with docker buildkit, the google auth keyring does not work, because the docker builder needs to be building on --network=cloudbuild, but --network=cloudbuild is an unsupported network on docker buildkit builder