Skip to content

BQ Anomaly detection: Reshuffle fanout in cdc#3621

Merged
claudevdm merged 1 commit into
GoogleCloudPlatform:mainfrom
claudevdm:cdc-reshuffle-refactor
Apr 2, 2026
Merged

BQ Anomaly detection: Reshuffle fanout in cdc#3621
claudevdm merged 1 commit into
GoogleCloudPlatform:mainfrom
claudevdm:cdc-reshuffle-refactor

Conversation

@claudevdm
Copy link
Copy Markdown
Contributor

Update cdc to match apache/beam#38015

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simplifies the CDC Arrow batch decompression process by replacing a complex, manual sharding implementation with a more idiomatic Apache Beam Reshuffle. This change removes unnecessary configuration parameters and streamlines the data processing flow, aligning the implementation with recent updates in the Apache Beam codebase.

Highlights

  • Refactored CDC Decompression Fan-out: Replaced the custom manual sharding logic (using GroupByKey with a custom trigger) with a standard beam.Reshuffle for fan-out, simplifying the pipeline and improving maintainability.
  • Configuration Cleanup: Removed the 'decompress_shards' configuration parameter and replaced it with a boolean 'reshuffle_decompress' flag, simplifying the user interface for CDC decompression.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.03%. Comparing base (52f460a) to head (5426a03).
⚠️ Report is 53 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (52f460a) and HEAD (5426a03). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (52f460a) HEAD (5426a03)
10 1
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3621       +/-   ##
=============================================
- Coverage     52.22%   37.03%   -15.20%     
+ Complexity     6053      470     -5583     
=============================================
  Files          1040      194      -846     
  Lines         62985    11387    -51598     
  Branches       6901     1130     -5771     
=============================================
- Hits          32896     4217    -28679     
+ Misses        27867     6832    -21035     
+ Partials       2222      338     -1884     
Components Coverage Δ
spanner-templates ∅ <ø> (∅)
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration ∅ <ø> (∅)
spanner-live-reverse-replication ∅ <ø> (∅)
spanner-bulk-migration ∅ <ø> (∅)
gcs-spanner-dv ∅ <ø> (∅)
see 871 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claudevdm claudevdm requested a review from damccorm April 2, 2026 15:55
Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm
Copy link
Copy Markdown
Contributor

damccorm commented Apr 2, 2026

Lets get a green signal on the python tests before merging

@damccorm damccorm added the addition New feature or request label Apr 2, 2026
@claudevdm claudevdm merged commit d7c872a into GoogleCloudPlatform:main Apr 2, 2026
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants