Handle missing dataproc-role metadata in hive-lineage.sh

[codelixir]

Replaces the curl -f call to the metadata server with the safer /usr/share/google/get_metadata_value utility to retrieve the dataproc-role attribute.

This change ensures the initialization action completes successfully even if the metadata key is not yet present, by using the standard Dataproc metadata helper and providing a fallback.

[gemini-code-assist]

Summary of Changes

Hello @codelixir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the hive-lineage.sh script by improving how it retrieves the dataproc-role metadata. By switching from a direct curl call to the dedicated get_metadata_value utility and incorporating a fallback, the script is now more resilient to transient metadata availability issues, preventing initialization action failures and ensuring smoother operation.

Highlights

• Metadata Retrieval: Replaced the direct curl command for fetching dataproc-role metadata with the more robust /usr/share/google/get_metadata_value utility.
• Error Handling: Introduced a fallback mechanism (|| echo "Unknown") to ensure the script completes successfully even if the dataproc-role metadata key is not immediately available.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codelixir]

/gcbrun

[gemini-code-assist]

Code Review

This pull request improves the robustness of the hive-lineage.sh initialization script by replacing a curl command with the safer /usr/share/google/get_metadata_value utility. This change correctly prevents the script from failing if the dataproc-role metadata is not immediately available. The implementation is sound. I have one suggestion to declare the ROLE variable as local to improve encapsulation and adhere to shell scripting best practices.

[gemini-code-assist]

To improve encapsulation and prevent the ROLE variable from potentially leaking into the global scope, it's a good practice to declare it as a local variable within the function.

Suggested change

	ROLE=$(/usr/share/google/get_metadata_value attributes/dataproc-role || echo "Unknown")
	local ROLE=$(/usr/share/google/get_metadata_value attributes/dataproc-role || echo "Unknown")

[codelixir]

Presubmit failure:

ERROR: Error computing the main repository mapping: Error accessing registry https://bcr.bazel.build/:
Failed to fetch registry file https://bcr.bazel.build/modules/apple_support/1.5.0/MODULE.bazel:
PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed

Update: on retrying, the same error message for https://bcr.bazel.build/modules/platforms/0.0.7/MODULE.bazel